Repository navigation
chore: take the CI workflows out of the tree for now - #898
Merged
Merged
Conversation
Removes .github/workflows/build-engines.yml and publish-npm.yml. The workflows go back in later, together with the rest of CI. Only the workflow files. Everything else that makes engines shippable stays: the engine resolution in run-souffle.sh, graph/pipeline/engine.conf, packaging/ and the optionalDependencies entries are untouched, so a checkout still resolves a packaged engine and still falls back to a local compile. Two places named the workflows and would have dangled: the README told the reader to publish from Actions, and a comment in the executor named publish-npm.yml as the thing that produces the package. Both now describe what is actually in the tree.
swapnilpaliwal-sd
force-pushed
the
chore/remove-workflows-for-now
branch
from
September 18, 2026 05:32
cff8e02 to
49d32f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes
.github/workflows/build-engines.ymlandpublish-npm.ymlout of the tree for now. They go back in later with the rest of CI.Only the workflows
Everything else from #478 stays. The engine resolution in
run-souffle.sh,graph/pipeline/engine.conf,packaging/and theoptionalDependenciesentries are untouched, so a checkout still resolves a packaged engine when one is installed and still falls back to a local compile when it is not.Two references would have dangled
README.mdtold the reader to publish from Actions, publish-npm, Run workflow. It now says the packages are assembled withpackaging/assemble-engine-package.shand published by hand until the workflows return.publish-npm.ymlas the thing that produces the package. It now names the package without naming the workflow.Note
While the workflows are out, nothing builds the engines automatically, so a release means running the build by hand on each platform.
packaging/assemble-engine-package.shstill takes anengines-<platform>/directory and produces the publishable package, so the packaging half is unaffected.