Repository navigation
javascript: a test that never loads the change is not selected; a mocha load-time throw selects the whole run - #1894
Merged
Conversation
Measured against runtime traces on the Python oracle corpus, every false
transitive-reach row has a static edge the runtime never made (the scorer
accepts any runtime caller at any depth, so context-insensitivity cannot
produce one). Two of the edge kinds are wrong by construction and are
fixed here; reach precision 0.675 -> 0.724, reach recall -0.1pt (src) /
-0.2pt (test-side), test-file recall -0.1pt, callers and path unchanged.
1. A decoration string naming a PARAMETER of the decorated declaration is
no registration key (ax_registration.decoration_key_strings, shape 4),
nor is a string inside another call in the decoration (shape 5).
`@option("--params", "-p", "params") def main(params)`: the flags are
what a caller writes to reach the command; the parameter name is written
by every function that builds a dict with that key, and the by-key join
made each of them a caller of the command. The flags stay keys.
2. The "decorator by name" hop lands on what the decorator RETURNS, not on
the decorator's body. It used to run decorated -> decorator, making the
decorated function (and everything reaching it: a route's tests) a
caller of whatever the decorator calls. Calling the decorated name never
runs the decorator; it runs what the decorator returned:
- bare `@d`: d's return; written as a call `@d(...)`: the return of
what d returned (decorated_call);
- a wrapper (fn_returns, from the engine's method_returns_method): the
decorated declaration now stands for that wrapper;
- the function handed back unchanged (fn_returns_param, a registering
decorator): no hop at all; the decoration itself runs at import,
which the import walk already follows;
- unknown return: the old hop stays (a route the walk cannot judge).
IMPACT_VERSION 70 (new facts fn_returns, fn_returns_param, decorated_call).
Cases: decorator-by-name-runs-its-wrapper, option-parameter-name-is-no-key
(each fails on the base, with a control that must not change);
decorator-the-project-declares now expects the route it really takes
(`at import`) instead of the by-name hop.
Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
… its class `cls: type[X] | None = None` and `Optional[Type[X]]` are the default-None spelling of a class-object parameter: the body swaps None for a default class and calls `cls(...)`. Only a top-level `type[...]` annotation was read, so the call stayed `callee_is_parameter` and every constructor behind it lost that caller (a decorator factory building its command class in a closure is the common shape). param_class_object_ref now names the `type[...]` subscript an annotation is or one of its union operands is, and both the concrete (expr_type_class_object) and the bounded-TypeVar (param_class_object_bound) rules read it. The existing top-level rules are unchanged. Corpus: one-hop callers src 0.828 -> 0.829, path found 0.727 -> 0.729, test->target path 0.559 -> 0.562; reach and tests unchanged; engine suite and torture unchanged (agree 588 / missing 46 / extra 37); index time flat. Case: optional-class-object-parameter (fails on the base; the bare `type[Command]` control passes on both). Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
…ha load-time throw selects the whole run
impact
- imports_fact resolves a directory import (`require('..')`, `require('../')`, a folder with a
package.json main/exports), the repository's own package name, a side-effect `import './x'` and a
literal `import('./x')`; a package whose entry is a build output the checkout lacks names its
src/ (or lib/) entry. imports_dynamic records the files that load a module by a computed name.
- loads_change asks whether the test loads the asked declaration's FILE, not the end of the
shortest route (which can run through another test file's subclass or callback); it says nothing
where the target file has no importer, the test file imports nothing here, or the test's import
closure holds a computed-name loader.
- a JavaScript test whose route is in-process (sound, one of a set, dispatch, registered, defines,
fixture) and whose file never loads the changed file is kept apart as `not_loading_tests` and
named on a `not counted:` line, never selected: a plugin's prototype override is credited only to
the tests that load the plugin, and a callback one test file hands to a shared function no longer
pulls in every other caller's tests. Key joins, remote hops and spawns are unaffected.
- load_run (impact.dl): test-code declarations that reach the change through calls alone; a test
credited through its module body or describe() block that is one of them carries `at_load`.
path
- from a JavaScript test file that never loads the target's file: "no route: X never loads Y".
test-impact
- a selected JavaScript file no runner collects is replaced by the collected test files that
require it, or moved to not_collected when none does (unless a test file loads modules by a
computed name).
- a mocha run whose specs reach the change at load time (`at_load`) lists every spec that run
collects: mocha loads them in one process and a throw there fails all of them. jest/vitest are
per-file and unchanged.
- a changed function-constructor (`function Foo(opts) {` header edit is a TYPE to `changed`) is asked
again as the function when impact finds no type at that line.
Measured on 8 JavaScript subjects against cached mutation truth (no-library protocol), base ->
this: impact R 0.522 -> 0.542, P 0.238 -> 0.295; tests R 0.494 -> 0.559, P 0.264 -> 0.310; held-out
impact P 0.156 -> 0.478 at equal recall; no failing (test file, target) pair lost in impact, tests
or path on any subject.
Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
IMPACT_VERSION 70 carries both 69s (the library-callback receiver sites and the JavaScript import facts). Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
marked this pull request as ready for review
October 10, 2026 17:40
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
October 10, 2026 17:40
…o fix/js-impact-f1 # Conflicts: # plugins/axiomcode/skills/axiomcode/scripts/axiomcode-impact
Closed
5 tasks done
Contributor
Author
|
Tracked in #1897 (0.1.9 batch); merge in the order listed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript test selection: a test that never loads the change is not selected, a mocha load-time throw selects the whole run, and the import facts behind both read
require('..')and a package's own name.What changes
impact
imports_factresolves a directory import (require('..'),require('../'), a folder with a package.jsonmain/exports), the repository's own package name, a side-effectimport './x'and a literalimport('./x'); a package whose entry is a build output the checkout lacks names itssrc/(orlib/) entry. Before, the root normalised to.and was tried as./index.js, so most CommonJS test suites imported nothing here andloads_changewas false for over a thousand failing test files on one subject.loads_changeasks whether the test loads the asked declaration's file, not the end of the shortest route (that route can run through another test file's subclass). It says nothing where the target file has no importer, the test imports nothing here, or a computed-name loader (require(path.join(dir, f))) sits in its import closure (imports_dynamic).not_loading_testsand anot counted:line instead of the selection. Key joins, remote hops and spawned scripts are unaffected (the existing key-join case keeps its test).load_run(impact.dl): test code that reaches the change through calls alone (a resolved call or one of a resolved set, nodefines, no hand-over). A test credited through its module body or describe() block that is one of these carriesat_load.path — from a JavaScript test file that never loads the target's file:
no route: X never loads Y, exit 1.test-impact
requireit, or moved tonot_collectedwhen none does (kept when a test file loads modules by a computed name).changed; when impact finds no type at that line it is asked again as the function (before: "could not be resolved to a graph symbol", 0 tests).Measured
8 JavaScript libraries (5 tuning, 3 held-out) from the 18-repo mutation corpus, cached truth (test files that newly fail when a function throws on entry), the archived no-library protocol; base reproduces the archived numbers exactly. Micro recall / precision:
No failing (test file, target) pair is lost by impact, tests or path on any subject; every change in recall is a gain. Path precision is estimated on a fixed sample of the base engine's non-failing selections.
With the runtime dependencies staged on the web-framework subject: tests R 0.460 -> 0.841, P 0.607 -> 0.706.
Cost: cold-solve impact median unchanged on the three largest subjects (0.46/0.46 s, 0.50/0.48 s, 0.31/0.31 s);
testswithin ±10%.Tests
tests/cases/javascript/a-test-that-never-loads-the-change: 3 checks fail on base, pass here; 4 controls (computed-name loader,require('..')/'../'/'../index.js', self-name import, the route of the test that does load the plugin) pass on both.tests/cases/javascript/mocha-load-time-fails-the-whole-run: 3 checks fail on base, pass here; controls: a test-body-only change selects its spec alone, and a jest package is not widened.python3 tests/run.py(all five languages): 1607 of 1607 checks pass.Not addressed
parse()reaching help and error paths behind flags): per-test-file coverage shows the false pairs never execute the target; no static signal without path conditions.module.exports(...), and a parameter defaulted asapp = app || new App(), leave one held-out subject's request/response tests unreached (one repo; not tuned on held-out).