Repository navigation
Release 0.1.2: promote dev to main (Windows wildcard fix) - #1371
Merged
Merged
Conversation
Git Bash's runtime globs the arguments a native Windows process passes it, since no shell did. The npm launcher and the MCP server start bash with `*` unquoted, so `axiomcode path '*' X` reached the CLI as the working directory's file names. The release e2e caught it on its first Windows run. withPython, the environment every launcher (CLI, MCP, hooks) hands to bash, now adds noglob to MSYS on Windows, keeping any MSYS options the user set. Verified on Windows Server 2022: `axiomcode path * square` answered for file names before and for `*` after.
windows: stop Git Bash expanding '*' in the CLI's arguments (#1369)
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 26, 2026 10:08
swapnilpaliwal-sd
enabled auto-merge
September 26, 2026 10:08
swapnilpaliwal-sd
disabled auto-merge
September 26, 2026 10:08
swapnilpaliwal-sd
enabled auto-merge
September 26, 2026 10:14
swapnilpaliwal-sd
disabled auto-merge
September 26, 2026 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote dev to main: release 0.1.2 (second attempt)
The first release build (#1368) passed on linux-x64, linux-arm64, darwin-arm64 and darwin-x64. It failed on win32-x64 on one new e2e check,
path '*' leaf: Git Bash expanded*into the working directory's file names (#1369). That bug had been in every release on Windows; the extended e2e found it on its first Windows run.Since then:
noglobtoMSYSon Windows, so*reaches the CLI as*. Verified on Windows Server 2022.No rules or build files changed since the last build, so the engines built for #1368 should come back from the cache: this build should take minutes, not an hour. The five-platform e2e then runs again. When it is green, axiomcode-bot tags
v0.1.2and drafts the release.