Fix compilation cache setting name and Swift compilation mode value#17
Merged
Fix compilation cache setting name and Swift compilation mode value#17
Conversation
Closes #14 - Rename `COMPILATION_CACHING` to `COMPILATION_CACHE_ENABLE_CACHING` across all skills, scripts, references, and documentation to match the actual Xcode build setting key. - Change `SWIFT_COMPILATION_MODE` debug expected value from `incremental` to `singlefile` — the actual build setting value that xcodebuild outputs. Xcode UI labels this "Incremental", but the underlying value is `singlefile`. - Update the `_check()` guard in generate_optimization_report.py so unset SWIFT_COMPILATION_MODE still passes when the expected value is `singlefile`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #14
COMPILATION_CACHING→COMPILATION_CACHE_ENABLE_CACHING: The build setting key used throughout all skills, scripts, references, and documentation was incorrect. Xcode's actual build setting key isCOMPILATION_CACHE_ENABLE_CACHING. This fix updates all 23 affected files including the benchmark detection logic inbenchmark_builds.py(thestartswith()check) and the expectation tuples ingenerate_optimization_report.py.SWIFT_COMPILATION_MODEdebug valueincremental→singlefile: The expected value in the report generator and orchestration template usedincremental, butxcodebuild -showBuildSettingsoutputssinglefile. Xcode's UI displays "Incremental", but the underlying build setting value issinglefile. Updated the_DEBUG_EXPECTATIONStuple and the_check()guard that handles unset values.Test plan
generate_optimization_report.pycorrectly matchesCOMPILATION_CACHE_ENABLE_CACHING = YESin build settings outputbenchmark_builds.pydetects compilation caching via the correctedstartswith("COMPILATION_CACHE_ENABLE_CACHING")checkSWIFT_COMPILATION_MODEaudit passes when build settings reportsinglefilefor DebugSWIFT_COMPILATION_MODEstill treated as passing for Debug (Xcode defaults tosinglefile)