Skip to content

AI/copilot uplift#146

Merged
chullybun merged 72 commits into
release/4from
es/ai-agent-uplift
Jun 19, 2026
Merged

AI/copilot uplift#146
chullybun merged 72 commits into
release/4from
es/ai-agent-uplift

Conversation

@chullybun

Copy link
Copy Markdown
Collaborator

Review co-pilot instructions.
Review coreex.expect agent.
Add AGENTS.md to all packages.

Review coreex.expect agent.
Add AGENTS.md to all packages.
Copilot AI review requested due to automatic review settings May 27, 2026 17:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR uplifts the repository’s AI/developer guidance by packaging per-NuGet AGENTS.md files, expanding/refreshing Copilot instruction sets and skills documentation, and aligning sample contracts/documentation with the updated conventions.

Changes:

  • Pack per-package README.md and new AGENTS.md files into NuGet packages for AI tooling consumption.
  • Refresh .github/instructions/* guidance (services, repositories, validators, hosts, tests, subscribers, tooling) and update the coreex-expert agent source list.
  • Minor sample/doc updates (e.g., [Contract] on sample contracts; application-layer docs wording; various README touch-ups).

Reviewed changes

Copilot reviewed 53 out of 54 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/Directory.Build.props Packs per-package README.md + AGENTS.md into NuGet when present.
src/CoreEx/README.md Expands error/exception documentation and adds AI usage guide note.
src/CoreEx/AGENTS.md Adds CoreEx AI usage guide (exceptions, ExecutionContext, Result<T>, etc.).
src/CoreEx.Validation/README.md Adds AI usage guide note.
src/CoreEx.Validation/AGENTS.md Adds validation AI usage guide and examples.
src/CoreEx.UnitTesting/README.md Adds AI usage guide note.
src/CoreEx.UnitTesting/AGENTS.md Adds unit testing AI usage guide (expectations, seeding, etc.).
src/CoreEx.RefData/README.md Adds AI usage guide note.
src/CoreEx.RefData/AGENTS.md Adds reference data AI usage guide (CodeGen-first approach).
src/CoreEx.Events/README.md Adds AI usage guide note.
src/CoreEx.Events/AGENTS.md Adds events AI usage guide (outbox/queueing patterns).
src/CoreEx.EntityFrameworkCore/README.md Fixes a duplicated line and adds AI usage guide note.
src/CoreEx.EntityFrameworkCore/AGENTS.md Adds EF Core integration AI usage guide.
src/CoreEx.DomainDriven/README.md Adds AI usage guide note.
src/CoreEx.DomainDriven/AGENTS.md Adds DDD AI usage guide (entities/aggregates/persistence state).
src/CoreEx.Database/README.md Adds AI usage guide note.
src/CoreEx.Database/AGENTS.md Adds database AI usage guide (IDatabase/command/mappers/error conventions).
src/CoreEx.Database.SqlServer/README.md Adds AI usage guide note.
src/CoreEx.Database.SqlServer/AGENTS.md Adds SQL Server AI usage guide (session context/outbox).
src/CoreEx.Database.Postgres/README.md Adds AI usage guide note.
src/CoreEx.Database.Postgres/AGENTS.md Adds Postgres AI usage guide (outbox/error code conventions).
src/CoreEx.Data/README.md Adds AI usage guide note.
src/CoreEx.Data/AGENTS.md Adds data/UoW AI usage guide (TransactionAsync, QueryArgsConfig).
src/CoreEx.CodeGen/README.md Adds AI usage guide note.
src/CoreEx.CodeGen/AGENTS.md Adds CodeGen AI usage guide (ref-data yaml, generated ownership).
src/CoreEx.Caching.FusionCache/README.md Adds AI usage guide note.
src/CoreEx.Caching.FusionCache/AGENTS.md Adds FusionCache AI usage guide (IHybridCache, registration).
src/CoreEx.Azure.Messaging.ServiceBus/README.md Adds AI usage guide note.
src/CoreEx.Azure.Messaging.ServiceBus/AGENTS.md Adds Service Bus AI usage guide (publisher/subscribe host wiring).
src/CoreEx.AspNetCore/README.md Updates ValidationException HTTP mapping wording; adds AI usage guide note.
src/CoreEx.AspNetCore/Mvc/README.md Updates ValidationException mapping wording (422 → 400) in docs.
src/CoreEx.AspNetCore/AGENTS.md Adds ASP.NET Core AI usage guide (WebApi patterns, middleware order).
src/CoreEx.AspNetCore.NSwag/README.md Updates standard ProblemDetails response wording; adds AI usage guide note.
src/CoreEx.AspNetCore.NSwag/AGENTS.md Adds NSwag AI usage guide.
samples/src/Contoso.Products.Contracts/ProductReserve.cs Marks contract as [Contract] + partial.
samples/src/Contoso.Products.Contracts/ProductLite.cs Marks contract as [Contract] + partial.
samples/docs/application-layer.md Clarifies policy purpose (I/O-dependent guard logic).
.github/skills/add-capability/SKILL.md Points to updated tooling instruction doc.
.github/skills/add-capability/references/workflow.md Updates workflow reference to tooling instructions.
.github/namespace_readme_template.md Adds README authoring template for namespace docs.
.github/instructions/validators.instructions.md Expands validator guidance (base class choices, DI, dictionary validators, etc.).
.github/instructions/tooling.instructions.md Introduces combined *.CodeGen + *.Database tooling conventions doc.
.github/instructions/tests.instructions.md Updates testing conventions (outbox helpers, mocking, relay/subscribe patterns).
.github/instructions/repositories.instructions.md Expands infra guidance (EfDb patterns, mapping, adapters/typed clients, etc.).
.github/instructions/host-setup.instructions.md Significantly expands Program.cs host composition guidance by host type.
.github/instructions/event-subscribers.instructions.md Expands subscriber patterns, error handling, and Program.cs wiring guidance.
.github/instructions/domain.instructions.md Adds new domain-layer conventions doc.
.github/instructions/database-project.instructions.md Removes older DB-only conventions doc (replaced by tooling instructions).
.github/instructions/contracts.instructions.md Expands contract guidance (unified API/event surface, generated ownership).
.github/instructions/application-services.instructions.md Expands service orchestration guidance (TransactionAsync, adapters, policies, mapping).
.github/instructions/api-controllers.instructions.md Expands controller guidance (result-based variants, $query schema endpoint).
.github/INSTRUCTION_AUTHORING.md Major update: instruction authoring principles, formatting, and generated-code ownership.
.github/copilot-instructions.md Updates global conventions (layering, tooling, generated ownership, testing notes).
.github/agents/coreex-expert.agent.md Updates agent “sources of truth” list and operating rules.

Comment thread .github/instructions/tests.instructions.md Outdated
Comment thread .github/instructions/event-subscribers.instructions.md Outdated
Comment thread .github/instructions/tooling.instructions.md Outdated
Comment thread src/CoreEx.DomainDriven/AGENTS.md Outdated
Comment thread src/CoreEx.Validation/AGENTS.md
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>
Copilot AI review requested due to automatic review settings May 27, 2026 17:19
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 53 out of 54 changed files in this pull request and generated 4 comments.

Comment thread src/CoreEx.DomainDriven/AGENTS.md Outdated
Comment thread src/CoreEx.Validation/AGENTS.md
Comment thread .github/instructions/event-subscribers.instructions.md Outdated
Comment thread .github/instructions/coreex-tooling.instructions.md
Copilot AI review requested due to automatic review settings May 27, 2026 18:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 55 out of 56 changed files in this pull request and generated 10 comments.

Comment thread src/CoreEx.AspNetCore/Mvc/README.md Outdated
Comment thread src/CoreEx/README.md Outdated
Comment thread samples/src/Contoso.Products.Contracts/ProductLite.cs Outdated
Comment thread samples/src/Contoso.Products.Contracts/ProductReserve.cs Outdated
Comment thread .github/instructions/coreex-host-setup.instructions.md
Comment thread .github/instructions/coreex-tests.instructions.md
Comment thread .github/instructions/tests.instructions.md Outdated
Comment thread .github/instructions/event-subscribers.instructions.md Outdated
Comment thread src/Directory.Build.props Outdated
Comment thread .github/instructions/tooling.instructions.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>
Copilot AI review requested due to automatic review settings May 27, 2026 19:36
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 55 out of 56 changed files in this pull request and generated 5 comments.

Comment thread src/CoreEx.AspNetCore.NSwag/README.md Outdated
Comment thread .github/instructions/coreex-host-setup.instructions.md
Comment thread .github/instructions/coreex-host-setup.instructions.md
Comment thread .github/instructions/coreex-host-setup.instructions.md
Comment thread .github/instructions/coreex-contracts.instructions.md
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>
Copilot AI review requested due to automatic review settings May 27, 2026 19:42
chullybun and others added 3 commits May 27, 2026 12:43
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 53 out of 54 changed files in this pull request and generated 6 comments.

Comment thread .github/instructions/tooling.instructions.md Outdated
Comment thread .github/instructions/coreex-host-setup.instructions.md
Comment thread .github/instructions/coreex-tests.instructions.md
Comment thread .github/instructions/coreex-tests.instructions.md
Comment thread .github/instructions/coreex-host-setup.instructions.md
Comment thread .github/instructions/coreex-host-setup.instructions.md Outdated
Copilot AI review requested due to automatic review settings May 28, 2026 20:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Fix tests post newline corrections.
Copilot AI review requested due to automatic review settings June 19, 2026 17:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings June 19, 2026 20:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings June 19, 2026 21:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings June 19, 2026 21:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings June 19, 2026 22:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@chullybun chullybun merged commit 7d4f625 into release/4 Jun 19, 2026
3 checks passed
@chullybun chullybun deleted the es/ai-agent-uplift branch June 19, 2026 23:08
chullybun added a commit that referenced this pull request Jun 20, 2026
* Initial v4.0.0 baseline.

* Azure Build & Deploy with azd (#138)

* Azure Build & Deploy with azd
and TF infra build

* Azure Build & Deploy with azd
and TF infra build

* Agentic dco fix 3 (#142)

* Merging from agentic separate branch/repo

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* updates for durable task

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* setting samples to target .net 10 only

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* making E2E target net10

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* fixing repo query

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* refactor: replace FluentAssertions with AwesomeAssertions in test projects

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* adding dts emulator to compose

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* feat: update test conventions and scaffold checklist to use AwesomeAssertions

Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* fix: apply PR review feedback - namespace, validation, item sync, routes, docs

Agent-Logs-Url: https://github.com/Avanade/CoreEx/sessions/6bd00f38-1dfa-43d7-bb5b-ffebc0d1b4a7

Co-authored-by: israels <3219628+israels@users.noreply.github.com>
Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* Merging from agentic separate branch/repo

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* updates for durable task

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* setting samples to target .net 10 only

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* making E2E target net10

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* fixing repo query

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* refactor: replace FluentAssertions with AwesomeAssertions in test projects

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* adding dts emulator to compose

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* feat: update test conventions and scaffold checklist to use AwesomeAssertions

Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* fix: apply PR review feedback - namespace, validation, item sync, routes, docs

Agent-Logs-Url: https://github.com/Avanade/CoreEx/sessions/6bd00f38-1dfa-43d7-bb5b-ffebc0d1b4a7

Co-authored-by: israels <3219628+israels@users.noreply.github.com>
Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>

* chore: update documentation and guidelines across various instruction files for clarity and consistency

Co-authored-by: Copilot <copilot@github.com>

* Refactor host setup instructions and enhance capability for messaging integration

- Cleaned up host setup instructions by removing unnecessary lines and improving clarity.
- Updated API host section to emphasize key registrations and middleware usage.
- Streamlined Subscribe host instructions to focus on essential configurations.
- Simplified Outbox Relay host guidance, highlighting minimal requirements.
- Created new authoring standards for instruction files to ensure consistency and maintainability.
- Established detailed workflows for adding capabilities and generating domains, enhancing user guidance.
- Introduced structured references for skills to improve discoverability and organization.

Co-authored-by: Copilot <copilot@github.com>

* feat: add comprehensive guide for CoreEx agent skills and workflows

* feat: update agent tools and enhance project configurations for multi-targeting support

Added some fixes for issues with failing tests running in parallel

* Removing accidental included deprecated files during merge.

* fix: correct project references and update null handling in OrderMapper

* fixing proper generator references in docs

* fix: update Order handling to preserve client-supplied identities and enhance validation

* fix: update Order query to ignore auto-includes for improved performance

* feat: implement IOrderWorkflowClient in order to mock and test orchestrated workflow

* copilot suggested fixes: update various files for consistency and improved clarity in code structure

---------

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: israels <3219628+israels@users.noreply.github.com>

* Es/r4 postgres (#143)

* CoreEx.Database.Postgres project introduction.

* Refactor Products sample to leverage PostgreSQL.

* Update to use interim schema for dbex yaml.

* Generator fixes.
Packaging improvements.

* DbEx finalized version.
Minor solution tweaks.

* Orders merge, and refactor/regen.
E2E testing uplift.

* CI.yml added.

* Fix CI.yml

* Add slnf files to aid CI.

* Further tweaks to CI and test fix.

* CI fix.

* Split parrallel and sequential for core to improve perf.

* Test fixes.

* Add retry to CircuitBreaker test.

* Fix parallelism for samples.

* Another parallelism fix.

* Another parallelism fix attemp?!

* Another parallelism crack :-(

* Fix async bug.

* NUnit result fix for retry.

* Another CI fix.

* Fixes related to PR comments.

* Re-gen sql procs.

* Tweaks based on review.

* Puch CI tweak.

* Another CI tweak.

* Sneak last - link to DTS from Aspire dashboard.

* Wrap up tweaks.

* CI tweak.

* Review feedback tweaks.

* Updating azure infra build to move Products to Postgres (#144)

* Updating azure infra build to move Products to Postgres

Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* fix: README.md updated for clean clone setup

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* adding helper scripts for aspire dashboard tokens and E2E runner config setup

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* adding ps1 variants of helper scripts.

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* fix: updating copilot review findings for the scripts

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* fix: removing the psql connection string parameter to disable cert validation.

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* removing terraform and it's references
it was infra only anyways without any code deploy

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* fix: updated ps1 to correctly get statuscodes

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* updating agents.md to include helper script info

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* fix: updated webapps to use keyvault connection strings for database and servicebus

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* reverting use of keyvault for webapps & fixing keyvault reuse

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* refactor: remove Key Vault references and update connection strings in Bicep and scripts

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* fix: update dev params for when keyvault env var doesn't exist

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

* fix: copilot review updates

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>

---------

Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>
Co-authored-by: Copilot <copilot@github.com>

* Es/ref data code gen (#145)

* Added CoreEx.CodeGen and related sample consumers. This performs code-generation of reference-data related .net artifacts.

* Mass README uplift.

* Samples/patterns documentation further described, include updates to key README's.

* Fixes based on review.

* Quick solution update to include sample docs.

* Correct review challenges; further .md updates.

* Fix service bus test.

* AI/copilot uplift (#146)

* Review co-pilot instructions.
Review coreex.expect agent.
Add AGENTS.md to all packages.

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>

* Updates based on review.

* Further review tweaks,

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>

* Review tweaks.

* Fix exclude.

* Consumerization of instructions.
Prefix instructions.

* Instructions consumerized and renamed.

* Agent and content sync.

* Update expert skill and related.

* Quiet recent .editorconfig changes

* More AI-related tweakings.

* Added CoreEx.Template (dotnet new).

* Contracts and Data instruction uplift

* removing old template approach

* Fix Database reference for correct templates.
Further instruction tweaks.

* Refactor domain generation and scaffolding processes

- Removed the `/generate-domain` skill and associated documentation, transitioning to a deterministic scaffolding approach using `CoreEx.Template` with `dotnet new coreex*` commands.
- Updated the agent interaction guide to reflect the new workflow and emphasize the use of `CoreEx Expert` for architectural guidance.
- Revised application scaffolding recommendations to align with the new template-based approach, replacing previous commands with appropriate `dotnet new` commands.
- Enhanced documentation across various guides to clarify the integration of templates and agent skills, ensuring a cohesive understanding of the development workflow.
- Streamlined the decision-making process for creating new domains and adding capabilities, emphasizing the importance of inspecting existing codebases before making changes.

* Enhance AI scaffolding capabilities and cleanup context files

- Added coreex-scaffold skill and prompt for guided solution scaffolding.
- Updated README.md to include AI-guided scaffolding instructions.
- Introduced consumer-specific AI context files for improved Copilot guidance.
- Removed outdated consumer AI context files and README.
- Updated project file to include new AI context assets during packaging.

* More AI testing/updating.

* Tooling dependency fixes.
Instruction tweaks.

* Enhance CoreEx bootstrap template and AI workflow assets for improved scaffolding experience

* improving skill UX

* adding workflow file

* fixing reference folder

* Enhance coreex-scaffold agent and workflow with improved interview mechanics and default selection policies

* adding new agent

* Refactor coreex-scaffold to solution-scaffolder; update documentation and agent references

* Fix errant JSON `.value` path issue in validation.
Update copilot instructions for validators unit tests.
Extend Shopping sample with unit tests created by AI.

* Better together.

* Refactor CoreEx scaffolding skills and workflows

- Deleted SKILL.md and workflow.md files for coreex-scaffold as they are no longer needed.
- Updated solution-scaffolder SKILL.md to enhance the description and workflow steps, including validation and project wiring.
- Improved interview mechanics in solution-scaffolder to ensure a more structured and user-friendly experience.
- Added validation rules to ensure generated projects are correctly wired and tested.
- Adjusted command patterns to clarify naming conventions for host templates.
- Removed unnecessary agent file references from CoreEx.Template.csproj.

* Rename

* Refactor CoreEx template to ensure compile safety and improve structure across API, Relay, and Subscriber projects

* Enhance solution scaffolding with local validation steps and add Docker Compose and Service Bus configuration files

* adding assets files

* Minimize summary tags in generated output.
Further instruction tweaks.

* Tweaks based on testing.

* fix: resolve token replacement issues in templates and update project references

- Corrected placeholder names for application layer references in API and Subscriber templates.
- Updated project reference paths in `app-name.Api.csproj` and `app-name.Subscriber.csproj`.

refactor: convert raw template directives to comment syntax

- Changed raw C# preprocessor directives to template engine-compatible comment syntax across various files.
- Updated `.cs`, `.csproj`, `.yaml`, and `.md` files to ensure proper processing by the template engine.

chore: enhance template engine configuration

- Added `specialCustomOperations` to `template.json` files for handling comment-based conditionals in multiple file types.

fix: correct Result API usage in PlaceholderSubscriber

- Updated `PlaceholderSubscriber.cs` to use `Result.Success` property instead of method.

test: implement comprehensive template pack validation scripts

- Created validation scripts for Windows and Linux/macOS to ensure template quality before publishing.
- Added scenarios to validate scaffolding and compilation of generated projects.

docs: update TEMPLATE_FIXES_SUMMARY.md with detailed changes and validation steps

- Documented all fixes applied to the CoreEx.Template pack, including validation procedures and quality assurance measures.

* fixing remaining template issues

* Fix template bootstrap: defer code-generation-dependent registrations and add Phase 2 guide

- Remove merge conflict markers from Api and Subscriber Program.cs
- Convert template conditionals from '// #if' to '#if' (proper C# syntax)
- Defer ReferenceDataService/ReferenceDataRepository registration to post-CodeGen
- Remove premature Application layer imports from GlobalUsing files
- Add clear comments referencing two-phase bootstrap workflow
- Create BOOTSTRAP_PHASE_2.md guide with step-by-step checklist

Scaffolded projects now compile immediately at Phase 1 (bootstrap), then require
Phase 2 (post-CodeGen) to enable reference-data features. This prevents compilation
failures when services/validators don't yet exist.

Fixes issues:
- Template conditionals now properly resolve at generation time
- No merge conflict markers in generated code
- Reference-data registrations deferred until after CodeGen runs
- Application layer imports only added after services exist

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix template conditional structure: proper #elif and #endif placement

- Move Postgres configuration block inside #elif (implement-postgres) conditional in Api Program.cs
- Convert commented conditionals to proper C# preprocessor syntax in Subscriber Program.cs
- Remove malformed // #elif and // #endif, replace with #elif and #endif
- Ensure all service builder chains are properly nested within their conditionals

This prevents conditional logic from being emitted into generated code unexpectedly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Refactor conditional compilation directives for improved readability and more stable/consistent consumption

- Updated conditional compilation directives in various project files to remove parentheses for consistency and clarity.
- Adjusted project references and package references in .csproj files to align with new directive style.
- Modified appsettings and documentation files to reflect the updated directive format.
- Ensured all relevant files across the CoreEx, Relay, and Subscriber projects are updated accordingly.

* API testing.

* Tweaks from the last round of API test prompting.

* Finalized AI-enabled API testing

* Relay template.

* Remove internal bootstrapping

* All files now 'UTF-8 without BOM'.

* Harden subscriber template.

* Finalize Subscribe host template.

* Add template emitted README.

* Doco updates.

* Migrate to slnx.
Fix tests post newline corrections.

* Template updates so core compiles.

* Renaming

* Continued renaming

* Fix CI

* Fix slnf files.

* Re-instated CoreEx.sln for backwards compat

* Re-gen orders to fix ci issue.

* Oops, committed before saving.

* Include missing build project.

---------

Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Israel Slobodkin <israel.slobodkin@avanade.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Renamed as Github.com preferences this README over root on homepage.

* Advance RefData gen to latest pattern for samples.

---------

Signed-off-by: Israel Slobodkin <israel.slobodkin@avanade.com>
Signed-off-by: Aaron Spruit <aaron.spruit@avanade.com>
Signed-off-by: Eric Sibly [chullybun] <eric@thesiblys.com>
Co-authored-by: spruit-avanade <86080272+spruit-avanade@users.noreply.github.com>
Co-authored-by: Israel <israelslobodkin@gmail.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: israels <3219628+israels@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Israel Slobodkin <israel.slobodkin@avanade.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants