Optimize cache enable/disable and update_mod_rewrite_rules#500
Merged
donnchawp merged 3 commits intoAutomattic:masterfrom Feb 14, 2018
Merged
Conversation
Contributor
|
Thanks again! You're really digging into some old code here. Those calls to wp_cache_replace_line() could even be replaced with calls to wp_cache_setting() now. And this proves how old some of this code is, I'm pretty sure WordPress doesn't have a gzipcompression option any more! |
Author
|
It'll be possible after merging #487. I think that current wp_cache_setting doesn't support boolean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$add_rulesis false.