fix: tolerate doctor archive churn - #2378
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENOENTat the per-entry archivestat/header-read boundary as benign concurrent churn.skippedcount without exposing vanished paths.Root Cause
archiveCheck()enumerated archive paths and then calledstat()and archive header validation without a per-entry disappearance boundary. A cache/runtime cleanup racing that inspection could remove an enumerated entry, allowingENOENTto escape and replace the doctor report withwp-codebox/cli-failure/v1.Error Boundary
inspectArchivePath()wraps only the individual entry'sstat()and header read.ENOENTreturns a skipped result; every other exception is rethrown. Rootopendir()failures also remain surfaced.Output Compatibility
The
wp-codebox/doctor/v1schema, statuses, messages, and existingchecked/invalidfields are unchanged. Archive details gain only a numericskippedfield; vanished paths are not reported.Verification
npx tsx tests/doctor-archive-inspection.test.tsnpx tsx scripts/doctor-command-smoke.tsnpx tsc -b packages/cli --pretty falsenpm run buildnpm run check(102-command gate passed; Docker-dependent MySQL E2E explicitly skipped because Docker is unavailable)No release or deployment occurred. No changelog, version, or generated release artifact was changed.
Fixes #2336