Skip to content

[Bug Report] Using URLSessionTask with a delegate fails tests on Linux #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
crazytonyli wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

[Bug Report] Using URLSessionTask with a delegate fails tests on Linux #1046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 60 additions & 1 deletion native/swift/Sources/wordpress-api/SafeRequestExecutor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,66 @@ extension WpNetworkRequest: NetworkRequestContent {
) async throws -> (Data, URLResponse) {
let request = try buildURLRequest(additionalHeaders: headers)
#if os(Linux)
return try await session.data(for: request)
class DummyDelegate: NSObject, URLSessionTaskDelegate, @unchecked Sendable {}

// Issue: `NonceAuthenticationTests` fails on Linux when using `session.dataTask(...)` with
// a delegate. This issue does not occur on macOS.
//
// `NonceAuthenticationTests` performs a request that involves a redirect: the login request
// `wp-login.php?redirect_to=/rest-nonce` results in an HTTP redirect to retrieve
// the REST nonce. This request fails on Linux, depending on how `URLSession` is used
// to send the request.
//
// I tested the following options (✅ means the test passes; ❌ means the test fails):

// Option 1: ✅
// return try await session.data(for: request)

// Option 2: ✅
// return try await session.data(for: request, delegate: delegate)

// Option 3: ✅
// let dummyDelegate = DummyDelegate()
// return try await session.data(for: request, delegate: dummyDelegate)

// Option 4: ❌
return try await withCheckedThrowingContinuation { continuation in
let task = session.dataTask(with: request) { (data, response, error) in
if let error = error {
continuation.resume(throwing: error)
} else {
continuation.resume(returning: (data!, response!))
}
}
task.delegate = delegate
task.resume()
}

// Option 5: ❌
// let dummyDelegate = DummyDelegate()
// return try await withCheckedThrowingContinuation { continuation in
// let task = session.dataTask(with: request) { (data, response, error) in
// if let error = error {
// continuation.resume(throwing: error)
// } else {
// continuation.resume(returning: (data!, response!))
// }
// }
// task.delegate = dummyDelegate
// task.resume()
// }

// Option 6: ✅
// return try await withCheckedThrowingContinuation { continuation in
// let task = session.dataTask(with: request) { (data, response, error) in
// if let error = error {
// continuation.resume(throwing: error)
// } else {
// continuation.resume(returning: (data!, response!))
// }
// }
// task.resume()
// }
#else
return try await session.data(for: request, delegate: delegate)
#endif
Expand Down