This repository was archived by the owner on Oct 16, 2024. It is now read-only.
Improved command for pulling PHP Errors from a Pressable site#185
Open
Improved command for pulling PHP Errors from a Pressable site#185
Conversation
Contributor
Author
|
Hi @tiagonoronha and @tommusrhodus! I pinged you about this because you were passionate about using the Pressable API to retrieve the error logs. This PR accomplishes exactly that with the added advantage of working also on sites that have WP_DEBUG turned on (or other means of changing the error log location). Ping me on Slack if you want examples of our sites that do that -- I didn't want to note them here publicly 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a new command for retrieving the PHP error logs of a Pressable site by leveraging the Atomic API when the default log location is used, and the legacy file parsing method when not.
For example, sites that have WP_DEBUG turned on will log all their errors in
/srv/htdocs/wp-content/debug.logwhereas the default location is/tmp/php-errors. The API only looks in the default location so we would miss out on all the PHP Fatal Error entries that occur after WP modified the error log location.The newly introduced
--sourceoption allows forcing retrieval either viaapior fromfileif the defaultautomode is not returning the expected results.Use like this:
team51 pressable:list-site-php-errors <site_id_or_url>team51 pressable:list-site-php-errors <site_id_or_url> --limit 25 --severity "Fatal error"team51 pressable:list-site-php-errors <site_id_or_url> --source fileFixes #173 and #184