Show File Manager label on Linux for the Open Folder button#3622
Open
ivan-ottinger wants to merge 4 commits into
Open
Show File Manager label on Linux for the Open Folder button#3622ivan-ottinger wants to merge 4 commits into
ivan-ottinger wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Linux-specific UI labeling by introducing a shared helper for the system file manager name and using it in both the Overview “Open in…” shortcut button and the site context menu label generation.
Changes:
- Added
getFileManagerLabel()to return “File Explorer” (Windows), “File Manager” (Linux), or “Finder” (macOS). - Updated
ContentTabOverviewandSiteMenuto use the new helper instead of a Windows-vs-mac fallback. - Updated affected component tests to mock the new helper.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/studio/src/lib/file-manager.ts | New helper that returns a localized platform-specific file manager label (adds Linux “File Manager”). |
| apps/studio/src/components/content-tab-overview.tsx | Uses getFileManagerLabel() for the Overview “Open in…” section first shortcut button label. |
| apps/studio/src/components/site-menu.tsx | Uses getFileManagerLabel() when building the context-menu payload label. |
| apps/studio/src/components/tests/content-tab-overview.test.tsx | Mocks src/lib/file-manager to keep component tests deterministic. |
| apps/studio/src/components/tests/content-tab-overview-shortcuts-section.test.tsx | Mocks src/lib/file-manager to keep component tests deterministic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Used Claude Code to locate the two label sites (the site-overview shortcut button and the site context menu) and add the Linux branch. I verified the changes, lint, typecheck, and ran the affected tests myself.
Proposed Changes
Testing Instructions
Pre-merge Checklist