Add Redis and Memcached support#2554
Add Redis and Memcached support#2554wojtekn wants to merge 3 commits intowojtekn/add/jspi-supportfrom
Conversation
2682186 to
fc8c5bf
Compare
📊 Performance Test ResultsComparing 7156837 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
1e061b2 to
cf0b171
Compare
247fa61 to
b1bade5
Compare
d205798 to
afc385b
Compare
b1bade5 to
029766e
Compare
afc385b to
38c814f
Compare
ivan-ottinger
left a comment
There was a problem hiding this comment.
All site operations still work well. I did not observe any issues with the CLI.
Regarding the reported slowdown of the site creation (+1010.00 ms | 🔴 14.2%), I run the performance test locally (3 rounds) and here are the results:
site-editor
┌────────┬─────────┬─────────┬───────────────┐
│ Metric │ trunk │ branch │ Diff │
├────────┼─────────┼─────────┼───────────────┤
│ load │ 2918 ms │ 1446 ms │ -50.4% faster │
└────────┴─────────┴─────────┴───────────────┘
site-startup
┌──────────────┬─────────┬─────────┬─────────────┐
│ Metric │ trunk │ branch │ Diff │
├──────────────┼─────────┼─────────┼─────────────┤
│ siteCreation │ 7044 ms │ 7047 ms │ +3 ms (~0%) │
├──────────────┼─────────┼─────────┼─────────────┤
│ siteStartup │ 3908 ms │ 3910 ms │ +2 ms (~0%) │
└──────────────┴─────────┴─────────┴─────────────┘
So in that front it is looking good as well. 🙂
sejas
left a comment
There was a problem hiding this comment.
The code looks good to me, and Sites start correctly, and I didn’t notice any performance degradation., although I’m not sure how to use Redis in my Studio sites. When installing https://wordpress.org/plugins/redis-cache/, I see the same error message as in trunk Redis is unreachable: Error while reading line from the server. [tcp://127.0.0.1:6379].
Same overview results for trunk and this branch:
The plugin diagnostics show the PhpRedis is installed for this PR:
Before / After Diff
Status: Not enabled
Client:
Drop-in: Not installed
Disabled: No
-PhpRedis: Not loaded
+PhpRedis: 6.3.0
Relay: Not loaded
Predis: 2.4.0
Credis: Not loaded
PHP Version: 8.3.30
Plugin Version: 2.7.0
Redis Version: Unknown
Multisite: No
Metrics: Disabled
Metrics recorded: 0
Filesystem: Writable
WP_REDIS_PLUGIN_PATH: "/wordpress/wp-content/plugins/redis-cache"
Drop-ins: [
"SQLite integration (Drop-in) v1.0.0 by WordPress Performance Team"
]
package-lock.json
Outdated
| }, | ||
| "node_modules/fs-xattr": { | ||
| "version": "0.3.1", | ||
| "hasInstallScript": true, |
There was a problem hiding this comment.
I think this is an unrelated change 🤔
@wojtekn, how do we actually test this? |
Related issues
Fixes STU-1178
Proposed Changes
I propose to enable Redis and Memcached PHP extensions for all Studio sites.
Testing Instructions
Confirm:
Pre-merge Checklist