Repository navigation
Mount test project at /home/debian/project instead of CircleCI path - #527
Merged
Merged
Conversation
The wp-test-runner image's project directory is /home/debian/project. /home/circleci is a CircleCI leftover that the image keeps only as a compatibility symlink, which is going to be removed from vip-container-images. Mount the project at the real path and pass APP_HOME and the working directory explicitly, so the runner finds vendor/ on current images and on older cached images with a different default home. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
__tests__/bin/test.shmounts the project at/home/circleci/project. That path is a leftover from CircleCI: thewp-test-runnerimage's real project directory is/home/debian/project(userdebian), and/home/circlecionly exists as a compatibility symlink in the image's Dockerfile. We plan to remove that symlink from Automattic/vip-container-images. Without it, this script would mount into a directory the runner doesn't use, and tests would fail before running with:This PR mounts the project at
/home/debian/projectand passes-e APP_HOMEand-wfor that path explicitly, so the runner findsvendor/and runs from the project directory on the current image and on older cached images with a different default home.Same change as Automattic/vip-go-mu-plugins#7300. CI doesn't use this script, so no workflow changes are needed.
Steps to Test
composer install.docker pull ghcr.io/automattic/vip-container-images/wp-test-runner:latest./__tests__/bin/test.shWorking directory: /home/debian/projectandPHPUnit executable: /home/debian/project/vendor/bin/phpunit, and tests run.Local result: OK (40 tests, 256 assertions, 2 skipped).
🤖 Generated with Claude Code