Skip to content

Conversation

@Szasza
Copy link

@Szasza Szasza commented Feb 26, 2023

Fixes #18

@Szasza
Copy link
Author

Szasza commented Feb 26, 2023

Hi @aroller ,

May I ask you for a review on this one please?

Thank you in advance.

@Szasza
Copy link
Author

Szasza commented Dec 12, 2023

Hi @ajanani85,

Is there a chance to get this change reviewed and if all is good, merged and tagged off with a new version?

Unfortunately @aroller didn't respond for some time now.

Thank you in advance for your help.

@Szasza
Copy link
Author

Szasza commented Dec 13, 2023

That you for the review @aroller , it is much appreciated. Not sure if there are any further steps needed from me in order to get this merged. If so, please let me know.

Thank you again.

@aroller
Copy link
Contributor

aroller commented Dec 13, 2023

I'm not involved in the repository any longer, but your change looked straightforward and required. I didn't see any testing so make sure it works. Otherwise merge if you can. I'm mobile and couldn't figure out how to merge for you in the app

@Szasza
Copy link
Author

Szasza commented Dec 13, 2023

@aroller thank you for the response. Unfortunately I don't have write access to the repo so cannot merge it. There should be a green merge button at the bottom of the comment thread if one has. Not sure who to ping to get it merged 😞

As for the tests, my fork is in use for a couple of months now on some private projects, so it definitely works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Deprecating set-output

2 participants