Repository navigation
Conversation
Baibhab23
requested review from
MeenakshiSarkar2692,
Sam007Yeah,
SuvabrataChowdhury,
Swastikanaha15,
WusatSami03 and
yash-khaitan
November 18, 2026 18:18
SuvabrataChowdhury
requested changes
Nov 19, 2026
SuvabrataChowdhury
left a comment
Collaborator
There was a problem hiding this comment.
Let's prioritize it before the bazel PR as we need to unify different builds through bazel commands.
Instead of fragile if-else decisions, we can use native docker based target builds.
| WORKDIR /app | ||
| COPY --from=build /home/app/target/pipeline*.jar app.jar | ||
| COPY --from=build /home/app/target/agents/opentelemetry-javaagent.jar otel-agent.jar | ||
| RUN --mount=type=bind,from=build,source=/home/app/target,target=/build-output \ |
Collaborator
There was a problem hiding this comment.
not sure if it is a valid syntax.
| COPY --from=build /home/app/target/pipeline*.jar app.jar | ||
| COPY --from=build /home/app/target/agents/opentelemetry-javaagent.jar otel-agent.jar | ||
| RUN --mount=type=bind,from=build,source=/home/app/target,target=/build-output \ | ||
| if [ "$ENABLE_OTEL" = "true" ] && [ -f /build-output/agents/opentelemetry-javaagent.jar ]; then \ |
Collaborator
There was a problem hiding this comment.
It's better to have a target build instead of this manual if-else routing. Docker natively supports target builds like this,
FROM node:22-alpine AS base
WORKDIR /app
COPY package*.json ./
RUN npm ci
FROM base AS dev
ENV NODE_ENV=development
COPY . .
CMD ["npm", "run", "dev"]
FROM base AS prod
ENV NODE_ENV=production
COPY . .
RUN npm run build
CMD ["node", "dist/server.js"]The specific target can be provided like this,
docker build --target prod -t myapp:prod .
docker build --target dev -t myapp:dev .
Collaborator
There was a problem hiding this comment.
Let's not have unnecessary scripts for builds if it can be done natively with Docker.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Issue Link
Changes Summary
Testing Done
yes
Pull Request Checklist
Additional Comments