Repository navigation
chore service wise docker files - #239
Conversation
Sam007Yeah
left a comment
There was a problem hiding this comment.
There's a lot of stuff going on please check with the scope of this chore. Also java side mainly @SuvabrataChowdhury has to check once.
SuvabrataChowdhury
left a comment
There was a problem hiding this comment.
We are supposed to be encouraging clean code and clean software projects as the core value of this project. If we ourselves have redundant changes in our project the completely disregards the vision itself! @Baibhab23 requesting please do a self-review of the changes before sending it for review. It helps both the reviewer, as they have to check less amount of changes which are essential to the backlog and the developer, as the send small simpler changes which are easy to modify during the review.
SuvabrataChowdhury
left a comment
There was a problem hiding this comment.
Changes are better now.. Few Points,
- Serve seems to be a larger binary.. it's fine as of this backlog but when we introduce nginx in our stack we should think about servicing it with nginx itself as it is way smaller binary.
- I still see random newline/ whitespace changes. These are probably left behind from previous changes. just copy and paste these files from master once and see of these redundant changes goes away.
- Include a
.env.localfile for spinning up the ui container. This will serve as a reference to how to configure the container. - Modify the docs and add the command to spinup the container.
SuvabrataChowdhury
left a comment
There was a problem hiding this comment.
let's not have unnecessary changes. Please check and resolve the comments.
SuvabrataChowdhury
left a comment
There was a problem hiding this comment.
Much cleaner now.. Please address the following comments.
f94934d to
b0611e7
Compare
SuvabrataChowdhury
left a comment
There was a problem hiding this comment.
Please address existing comments.. Not sure why we need to manually create the files and then change it's permission sets. lets keep dockerfiles simple for now.
Remove manual user/group creation and chown/mkdir steps per review feedback.
… condition to service_healthy
Sam007Yeah
left a comment
There was a problem hiding this comment.
As long as this is tested, the changes looks good to me
SUMMARY
Added service-wise Dockerfiles for the backend (pipeline) and frontend (pipeline-ui) services to enable containerised deployment of the full application stack.
Issue Link
Changes Summary
Testing Done
Pull Request Checklist
Additional Comments