Skip to content

chore service wise docker files - #239

Merged
Sam007Yeah merged 21 commits into
mainfrom
105-chore-service-wise-docker-files
Nov 18, 2026
Merged

Sam007Yeah merged 21 commits into
mainfrom
105-chore-service-wise-docker-files

Conversation

@Baibhab23

Copy link
Copy Markdown
Collaborator

SUMMARY

Added service-wise Dockerfiles for the backend (pipeline) and frontend (pipeline-ui) services to enable containerised deployment of the full application stack.

Issue Link

Link the Issue for which this PR was raised

Changes Summary

Implemented multi-stage Docker builds for both the backend and frontend to optimize image size, improve security, and simplify deployment. The backend uses Maven 3.8.3 and OpenJDK 17 for building, with a lightweight Eclipse Temurin JRE runtime, non-root execution, and OpenTelemetry instrumentation. The frontend uses Node.js 22 Alpine for building and Nginx Alpine for serving the React application, with configurable Vite and Keycloak settings for different environments. Also integrated both services into the local development environment, optimized Docker build contexts, configured Nginx routing, and added comprehensive backend unit tests to achieve at least 80% test coverage.

Testing Done

How has the solution been tested?
Yes

Pull Request Checklist

Tasks Yes/No
Issue Linked?
Timeline of the Issue is updated?
Do these changes affect local development in anyway? (if yes mention effects in additional comments)

Additional Comments

Anything else regarding this PR

@Baibhab23 Baibhab23 linked an issue Nov 1, 2026 that may be closed by this pull request
@Baibhab23 Baibhab23 changed the title 105 chore service wise docker files chore service wise docker files Nov 1, 2026

@Sam007Yeah Sam007Yeah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of stuff going on please check with the scope of this chore. Also java side mainly @SuvabrataChowdhury has to check once.

Comment thread pipeline-ui/Dockerfile Resolved
Comment thread pipeline-ui/Dockerfile Resolved
Comment thread pipeline-ui/Dockerfile.dockerignore Resolved
Comment thread pipeline-ui/nginx.conf Resolved
Comment thread pipeline-ui/tsconfig.app.json Resolved
Comment thread pipeline/Dockerfile Resolved
Comment thread docker-compose.yml Resolved

@SuvabrataChowdhury SuvabrataChowdhury left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are supposed to be encouraging clean code and clean software projects as the core value of this project. If we ourselves have redundant changes in our project the completely disregards the vision itself! @Baibhab23 requesting please do a self-review of the changes before sending it for review. It helps both the reviewer, as they have to check less amount of changes which are essential to the backlog and the developer, as the send small simpler changes which are easy to modify during the review.

Comment thread pipeline-ui/Dockerfile Resolved
Comment thread pipeline-ui/Dockerfile Resolved
Comment thread pipeline-ui/Dockerfile Resolved
Comment thread pipeline-ui/Dockerfile.dockerignore Resolved
Comment thread pipeline-ui/nginx.conf Resolved
Comment thread docker-compose.yml Resolved
Comment thread docker-compose.yml Resolved

@SuvabrataChowdhury SuvabrataChowdhury left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are better now.. Few Points,

  1. Serve seems to be a larger binary.. it's fine as of this backlog but when we introduce nginx in our stack we should think about servicing it with nginx itself as it is way smaller binary.
  2. I still see random newline/ whitespace changes. These are probably left behind from previous changes. just copy and paste these files from master once and see of these redundant changes goes away.
  3. Include a .env.local file for spinning up the ui container. This will serve as a reference to how to configure the container.
  4. Modify the docs and add the command to spinup the container.

Comment thread pipeline/Dockerfile Resolved
Comment thread docker-compose.yml Resolved
Comment thread pipeline-ui/Dockerfile Resolved
Comment thread pipeline-ui/tsconfig.app.json Resolved

@SuvabrataChowdhury SuvabrataChowdhury left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reducing the number of changes. please resolve some of the existing comments.

Comment thread pipeline-ui/Dockerfile Resolved
Comment thread pipeline/Dockerfile Resolved
Comment thread docker-compose.yml Resolved
Comment thread .env.local Resolved
Comment thread .env.local Resolved

@SuvabrataChowdhury SuvabrataChowdhury left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not have unnecessary changes. Please check and resolve the comments.

Comment thread pipeline-ui/.gitignore Resolved
Comment thread pipeline-ui/.env Resolved

@SuvabrataChowdhury SuvabrataChowdhury left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner now.. Please address the following comments.

Comment thread .env.local Resolved
Comment thread pipeline-ui/Dockerfile Resolved
Comment thread pipeline-ui/.env.local Resolved
@Baibhab23
Baibhab23 force-pushed the 105-chore-service-wise-docker-files branch from f94934d to b0611e7 Compare November 17, 2026 08:11

@SuvabrataChowdhury SuvabrataChowdhury left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address existing comments.. Not sure why we need to manually create the files and then change it's permission sets. lets keep dockerfiles simple for now.

Comment thread pipeline/Dockerfile Resolved
Comment thread pipeline/Dockerfile Resolved

@SuvabrataChowdhury SuvabrataChowdhury left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sam007Yeah Sam007Yeah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this is tested, the changes looks good to me

@Sam007Yeah
Sam007Yeah merged commit c85cbcd into main Nov 18, 2026
2 checks passed
@Sam007Yeah
Sam007Yeah deleted the 105-chore-service-wise-docker-files branch November 18, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[chore]: Service-wise Docker files

3 participants