Skip to content

Do not read document in getSiteName when there is none #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitjain099 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Do not read document in getSiteName when there is none #1592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
export async function getSiteName() {
const tab = await getCurrentTab();
const query = new URLSearchParams(document.location.search.substring(1));
// The popup passes the tab's title and url in its own query string. The MV3
// service worker calls this too and has no document, so fall back to the tab.
const query = new URLSearchParams(
typeof document !== "undefined" ? document.location.search.substring(1) : ""
);

let title: string | null;
let url: string | null;
Expand Down