Skip to content

fix(web): serialize addTrackToPlaylist saga to stop dropping bulk-added tracks #14422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dylanjeffers wants to merge 1 commit into from
Closed

fix(web): serialize addTrackToPlaylist saga to stop dropping bulk-added tracks #14422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions packages/web/src/common/store/cache/collections/addTrackToPlaylistSaga.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import {
Nullable
} from '@audius/common/utils'
import { Id } from '@audius/sdk'
import { call, put, takeEvery } from 'typed-redux-saga'
import { actionChannel, call, put, take } from 'typed-redux-saga'

import { make } from 'common/store/analytics/actions'
import { ensureLoggedIn } from 'common/utils/ensureLoggedIn'
Expand Down Expand Up @@ -65,11 +65,20 @@ const getCurrentTimestamp = () => {

/** ADD TRACK TO PLAYLIST */

// Process ADD_TRACK_TO_PLAYLIST one at a time. takeEvery let concurrent
// invocations race: each captured the cache snapshot before any had written
// back its optimistic update, and the last saga to finish overwrote the
// others — silently dropping their tracks on both the cache and the backend.
// This was visible when adding tracks in quick succession (e.g. via the
// add-tracks-by-URL modal): only the final track survived.
export function* watchAddTrackToPlaylist() {
yield* takeEvery(
cacheCollectionsActions.ADD_TRACK_TO_PLAYLIST,
addTrackToPlaylistAsync
const channel = yield* actionChannel<AddTrackToPlaylistAction>(
cacheCollectionsActions.ADD_TRACK_TO_PLAYLIST
)
while (true) {
const action = yield* take(channel)
yield* call(addTrackToPlaylistAsync, action)
}
}

function* addTrackToPlaylistAsync(action: AddTrackToPlaylistAction) {
Expand Down
Loading