Skip to content

fix: align PI profile links with affiliation order - #33

Merged
chengjiahao1234 merged 1 commit into
mainfrom
feature/team-pi-profile-link-order
Nov 13, 2026
Merged

chengjiahao1234 merged 1 commit into
mainfrom
feature/team-pi-profile-link-order

Conversation

@chengjiahao1234

Copy link
Copy Markdown
Collaborator

Type of Change

  • Bug Fix

Summary

Align the PI's institutional profile links with the displayed affiliation order: Concordia University, Mila, McGill University.

Changes Made

  • _includes/team-grid.html: render the Mila link before McGill, keeping the Concordia/personal website link first.
  • Update the template's link-order documentation.
  • Preserve all URLs, icons, accessible labels, role text, photos, and remaining links. Other existing team profiles are unchanged.

Testing Checklist

  • Desktop (1920x1080), tablet (768x1024), and mobile (375x667)
  • Light and dark themes
  • Local images load; link destinations are unchanged
  • No console errors or horizontal overflow
  • Ran bundle exec jekyll serve locally without errors
  • Jekyll build and git diff --check passed
  • Verified rendered link order and keyboard tab order
  • Compared all team cards against the pre-change page

Screenshots (if applicable)

Responsive screenshots reviewed locally; not attached.

Related Issues

Follow-up to #32.

Additional Notes

  • The PI is currently the only member with both Mila and McGill profile fields.
  • Existing non-blocking Ruby native-extension warnings remain; builds succeed.
  • Ready for admin review; not merged.

By submitting this PR, I confirm:

  • I have tested these changes locally
  • I have followed the code standards in DEVELOPMENT.md
  • I have updated documentation if needed
  • I am ready for this to be reviewed and merged

@chengjiahao1234
chengjiahao1234 merged commit a3c8eb8 into main Nov 13, 2026
1 check passed
@chengjiahao1234
chengjiahao1234 deleted the feature/team-pi-profile-link-order branch November 13, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant