Repository navigation
Conversation
Plain `let x = data.x` copies only the initial value, so a reused page component would keep showing stale data after a same-route navigation. Clears 14 state_referenced_locally warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pass type/accept to createDroppable as getters like id, so its internal effect re-reads them. Derive componentId, and mark the displayGrade seed as an intentional initial value with untrack. Clears 5 state_referenced_locally warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
flowbite-svelte's Tooltip already sets tabIndex=0 on its trigger at runtime (Popper.svelte), so keyboard users can still focus the icon and open the tooltip. Clears the a11y_no_noninteractive_tabindex warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
superForm owns the form state after init, so its initial data and the destructured superForm objects are read once on purpose; untrack makes that explicit. Lookup-only data (workBook, tasksMapByIds) is derived. Clears the last 10 state_referenced_locally warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
svelte-check and oxlint exit 0 on warnings by default, which let the 30 warnings fixed in this branch pile up unnoticed. Add --fail-on-warnings to check and --deny-warnings to oxlint in lint and the pre-commit hook. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oxlint does not lint .svelte files, so warnings such as no-explicit-any in Svelte components passed CI while the same rule failed in .ts files. Add --max-warnings 0 to eslint in lint and the pre-commit hook. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fold the phase checklists into decisions, rejected alternatives, verification results, unchecked items, and the Codex cross-review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With --max-warnings 0, ESLint's "File ignored because of a matching ignore pattern" warning for an explicitly passed file would block the commit. Add --no-warn-ignored (found in the Codex cross-review). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Turn two manual checks from the warning fixes into E2E tests: - the provisional-grade icon on /votes opens its tooltip on focus, which relies on flowbite-svelte making the trigger focusable; - the admin workbook create form pre-fills authorId, isOfficial, and the curriculum type. Seed a median (D3, from production) for the PENDING task zone2021_f so the icon is shown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4285
Summary by CodeRabbit