Release throttle permits only once#2280
Open
pavel-ptashyts wants to merge 1 commit into
Open
Conversation
A completion callback can reentrantly trigger onThrowable when a reactive subscriber disposes and cancels its future. ReleasePermitOnComplete then released the same acquired permit from both terminal callbacks, inflating the semaphore and overflowing when its count reached Integer.MAX_VALUE. Guard the release atomically while continuing to forward both callbacks to the wrapped handler. Add a regression test reproducing the reported completion-to-cancellation callback sequence. Fixes AsyncHttpClient#1797 Codex on behalf of Pavel Ptashyts Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
ReleasePermitOnCompletereleased the same acquired permit from bothonCompletedandonThrowable. A completion callback can synchronously cancelits future and reenter the wrapper through
onThrowable, causing both callbackframes to release the permit. This inflated the semaphore count and raised
java.lang.Error: Maximum permit count exceededat the maximum count.Validation
passed
ClientStatsTesttimeout-boundary failure, and another encountered transienttest-class artifact corruption; the final rerun was stopped at the operator's
request
Closes #1797
Codex on behalf of Pavel Ptashyts