Prune idle per-host connection semaphores#2277
Open
pavel-ptashyts wants to merge 1 commit into
Open
Conversation
Per-host connection limits retained one semaphore and partition key for every host observed by the client, even after all permits were returned. Track holders and waiting acquisitions for each map entry. Remove an entry only after the final reference leaves, so a concurrent acquisition cannot detach from the semaphore used by later callers. Codex on behalf of Pavel Ptashyts Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
PerHostConnectionSemaphoreretained one semaphore and partition key for every host observed by a client. Long-lived clients connecting to many distinct hosts could therefore retain these entries indefinitely.Testing
./mvnw -pl client -Dtest='org.asynchttpclient.netty.channel.SemaphoreTest#perHostRemovesEntriesAfterLastRelease+combinedRemovesEntriesAfterLastRelease+perHostRetainsEntryDuringWaitingAcquire' test./mvnw -pl client -Dtest='org.asynchttpclient.netty.channel.SemaphoreTest,org.asynchttpclient.netty.channel.ChannelManagerHttp2DrainPermitTest,org.asynchttpclient.netty.NettyRequestThrottleTimeoutTest' test(346 tests)./mvnw -B -ntp -pl client -DskipTests -Dmaven.javadoc.skip=true -Dgpg.skip=true verify(includes Revapi)The required JDK 11
./mvnw clean verifywas not run because JDK 11 is not available in the local environment. CI will exercise the complete supported JDK matrix.Codex on behalf of Pavel Ptashyts