Skip to content

Avoid unused promise allocation in address resolution #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavel-ptashyts wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Avoid unused promise allocation in address resolution #2259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,6 @@ private <T> void connectWithAddresses(Request request, ProxyServer proxy, NettyR
private <T> Future<List<InetSocketAddress>> resolveAddresses(Request request, ProxyServer proxy, NettyResponseFuture<T> future,
AsyncHandler<T> asyncHandler, boolean scheduleTimeout) {
Uri uri = request.getUri();
final Promise<List<InetSocketAddress>> promise = ImmediateEventExecutor.INSTANCE.newPromise();

if (proxy != null && !proxy.isIgnoredForHost(uri.getHost()) && proxy.getProxyType().isHttp()) {
int port = ProxyType.HTTPS.equals(proxy.getProxyType()) || uri.isSecured() ? proxy.getSecuredPort() : proxy.getPort();
Expand All @@ -584,6 +583,7 @@ private <T> Future<List<InetSocketAddress>> resolveAddresses(Request request, Pr
if (request.getAddress() != null) {
// bypass resolution
InetSocketAddress inetSocketAddress = new InetSocketAddress(request.getAddress(), port);
Promise<List<InetSocketAddress>> promise = ImmediateEventExecutor.INSTANCE.newPromise();
return promise.setSuccess(singletonList(inetSocketAddress));
}
return resolveHostname(request, unresolvedRemoteAddress, asyncHandler);
Expand Down
Loading