fix: make ChatUI model selection theme-aware#9200
Open
wcqqq1214 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the active background color of the provider menu item in ProviderModelMenu.vue to use a theme-based primary color with opacity. This change allows for the removal of the dark-theme-specific override, simplifying the stylesheet. There are no review comments to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The selected model item used the fixed light color
#f2f2f2. The fallback dark-mode selector targeted.v-theme--dark, while AstrBot uses named Vuetify themes such asv-theme--PurpleThemeDark, so the light background remained visible with white text in dark mode.Impact
The compiled selector remains scoped to
ProviderModelMenu.vueand only changes the active item background. Provider data, API calls, selection behavior, hover styles, and other list components are unchanged.Validation
cd dashboard && pnpm builduv run ruff format .uv run ruff check .--v-theme-primaryvalueFixes #9193
Summary by Sourcery
Make the ChatUI provider model selection background use Vuetify theme colors for better light/dark theme support.
Enhancements: