Skip to content

fix: make ChatUI model selection theme-aware#9200

Open
wcqqq1214 wants to merge 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/9193-chatui-theme
Open

fix: make ChatUI model selection theme-aware#9200
wcqqq1214 wants to merge 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/9193-chatui-theme

Conversation

@wcqqq1214

@wcqqq1214 wcqqq1214 commented Jul 10, 2026

Copy link
Copy Markdown

Summary

  • replace the hard-coded selected-model background with a Vuetify theme color
  • remove the ineffective generic dark-theme override
  • keep the change scoped to the ChatUI provider model menu

Root cause

The selected model item used the fixed light color #f2f2f2. The fallback dark-mode selector targeted .v-theme--dark, while AstrBot uses named Vuetify themes such as v-theme--PurpleThemeDark, so the light background remained visible with white text in dark mode.

Impact

The compiled selector remains scoped to ProviderModelMenu.vue and only changes the active item background. Provider data, API calls, selection behavior, hover styles, and other list components are unchanged.

Validation

  • cd dashboard && pnpm build
  • uv run ruff format .
  • uv run ruff check .
  • verified the selected item in the running ChatUI under both light and dark themes
  • confirmed computed backgrounds resolve from each theme's --v-theme-primary value

Fixes #9193

Summary by Sourcery

Make the ChatUI provider model selection background use Vuetify theme colors for better light/dark theme support.

Enhancements:

  • Use the Vuetify primary theme color for the active provider model menu item background instead of a hard-coded light color.
  • Remove the obsolete dark-theme-specific background override for active provider model menu items to rely on theme-derived styling.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the active background color of the provider menu item in ProviderModelMenu.vue to use a theme-based primary color with opacity. This change allows for the removal of the dark-theme-specific override, simplifying the stylesheet. There are no review comments to address.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@wcqqq1214 wcqqq1214 marked this pull request as ready for review July 10, 2026 03:36
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 10, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] ChatUI 模型下拉列表选中项背景色不随主题切换

1 participant