Update MiniMax TTS default model#9198
Open
octo-patch wants to merge 1 commit into
Open
Conversation
Use the current MiniMax HD speech model for new TTS provider configurations and lock the default with a focused regression test.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the default model for MiniMax TTS from 'speech-02-turbo' to 'speech-2.8-hd' in the configuration, and adds a corresponding unit test to verify this default setting. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The test hardcodes the provider display name key
"MiniMax TTS(API)", which could be brittle if the label changes; consider keying the lookup by a more stable identifier (e.g., provider id or enum) to make the test more robust. - Accessing deeply nested
CONFIG_METADATA_2["provider_group"]["metadata"]["provider"]["config_template"]directly in the test couples it tightly to the config structure; consider introducing a small helper or fixture that encapsulates this lookup so future structural changes only need to be updated in a single place.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The test hardcodes the provider display name key `"MiniMax TTS(API)"`, which could be brittle if the label changes; consider keying the lookup by a more stable identifier (e.g., provider id or enum) to make the test more robust.
- Accessing deeply nested `CONFIG_METADATA_2["provider_group"]["metadata"]["provider"]["config_template"]` directly in the test couples it tightly to the config structure; consider introducing a small helper or fixture that encapsulates this lookup so future structural changes only need to be updated in a single place.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: MiniMax TTS is integrated but still defaults to speech-02-turbo instead of the target speech-2.8-hd model.
Summary
speech-2.8-hd.Test plan
uv --directory /root/octopatch-4/work/repos/AstrBotDevs_AstrBot run --group dev pytest tests/unit/test_config.py -k minimax_tts_default_model_is_speech_28_hduv --directory /root/octopatch-4/work/repos/AstrBotDevs_AstrBot run --group dev ruff check astrbot/core/config/default.py tests/unit/test_config.pygit -C /root/octopatch-4/work/repos/AstrBotDevs_AstrBot diff --checkSummary by Sourcery
Update MiniMax TTS configuration to use the current HD speech model as the default and add a regression test to lock in this behavior.
New Features:
Enhancements:
Tests: