Skip to content

Update MiniMax TTS default model#9198

Open
octo-patch wants to merge 1 commit into
AstrBotDevs:masterfrom
octo-patch:octo/20260709-refresh-minimax-tts-default-to-speech-28-hd-recvoRQLxBrQF9
Open

Update MiniMax TTS default model#9198
octo-patch wants to merge 1 commit into
AstrBotDevs:masterfrom
octo-patch:octo/20260709-refresh-minimax-tts-default-to-speech-28-hd-recvoRQLxBrQF9

Conversation

@octo-patch

@octo-patch octo-patch commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Reason: MiniMax TTS is integrated but still defaults to speech-02-turbo instead of the target speech-2.8-hd model.

Summary

  • Update the built-in MiniMax TTS provider template to default to speech-2.8-hd.
  • Add a focused config regression test for the MiniMax TTS default model.

Test plan

  • uv --directory /root/octopatch-4/work/repos/AstrBotDevs_AstrBot run --group dev pytest tests/unit/test_config.py -k minimax_tts_default_model_is_speech_28_hd
  • uv --directory /root/octopatch-4/work/repos/AstrBotDevs_AstrBot run --group dev ruff check astrbot/core/config/default.py tests/unit/test_config.py
  • git -C /root/octopatch-4/work/repos/AstrBotDevs_AstrBot diff --check

Summary by Sourcery

Update MiniMax TTS configuration to use the current HD speech model as the default and add a regression test to lock in this behavior.

New Features:

  • Introduce a dedicated test asserting the default MiniMax TTS model in configuration metadata.

Enhancements:

  • Change the MiniMax TTS provider template default model from speech-02-turbo to speech-2.8-hd in the core configuration metadata.

Tests:

  • Add a focused unit test verifying that the MiniMax TTS default model is speech-2.8-hd via CONFIG_METADATA_2.

Use the current MiniMax HD speech model for new TTS provider configurations and lock the default with a focused regression test.
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default model for MiniMax TTS from 'speech-02-turbo' to 'speech-2.8-hd' in the configuration, and adds a corresponding unit test to verify this default setting. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The test hardcodes the provider display name key "MiniMax TTS(API)", which could be brittle if the label changes; consider keying the lookup by a more stable identifier (e.g., provider id or enum) to make the test more robust.
  • Accessing deeply nested CONFIG_METADATA_2["provider_group"]["metadata"]["provider"]["config_template"] directly in the test couples it tightly to the config structure; consider introducing a small helper or fixture that encapsulates this lookup so future structural changes only need to be updated in a single place.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The test hardcodes the provider display name key `"MiniMax TTS(API)"`, which could be brittle if the label changes; consider keying the lookup by a more stable identifier (e.g., provider id or enum) to make the test more robust.
- Accessing deeply nested `CONFIG_METADATA_2["provider_group"]["metadata"]["provider"]["config_template"]` directly in the test couples it tightly to the config structure; consider introducing a small helper or fixture that encapsulates this lookup so future structural changes only need to be updated in a single place.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant