Skip to content

fix(config): add missing websearch_firecrawl_key to DEFAULT_CONFIG#8012

Merged
RC-CHN merged 1 commit intoAstrBotDevs:masterfrom
Midwich:master
May 6, 2026
Merged

fix(config): add missing websearch_firecrawl_key to DEFAULT_CONFIG#8012
RC-CHN merged 1 commit intoAstrBotDevs:masterfrom
Midwich:master

Conversation

@Midwich
Copy link
Copy Markdown
Contributor

@Midwich Midwich commented May 5, 2026

The websearch_firecrawl_key config key was added in PR #7764 (Firecrawl web search provider) but was missing from DEFAULT_CONFIG in default.py.

Because AstrBotConfig.check_config_integrity() removes keys that exist in the user's cmd_config.json but are absent from DEFAULT_CONFIG, the firecrawl API key is silently deleted on every container restart.

Fixes: unreported issue (config key removed on restart)

Modifications / 改动点

  • Added websearch_firecrawl_key: [] to DEFAULT_CONFIG["provider_settings"] in astrbot/core/config/default.py to prevent the key from being removed by check_config_integrity() on restart.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Add the missing websearch_firecrawl_key entry to DEFAULT_CONFIG provider_settings so user-provided Firecrawl keys are no longer removed by config integrity checks.

The websearch_firecrawl_key config key was added in PR AstrBotDevs#7764 (Firecrawl
web search provider) but was missing from DEFAULT_CONFIG in default.py.

Because AstrBotConfig.check_config_integrity() removes keys that exist
in the user's cmd_config.json but are absent from DEFAULT_CONFIG, the
firecrawl API key is silently deleted on every container restart.

Fixes: unreported issue (config key removed on restart)
@auto-assign auto-assign Bot requested review from Fridemn and anka-afk May 5, 2026 08:09
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:provider The bug / feature is about AI Provider, Models, LLM Agent, LLM Agent Runner. labels May 5, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new configuration key websearch_firecrawl_key initialized as an empty list to the default configuration in astrbot/core/config/default.py. I have no feedback to provide as there are no review comments to evaluate.

@Midwich Midwich force-pushed the master branch 2 times, most recently from 2934ef8 to b129202 Compare May 5, 2026 08:25
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 6, 2026
@RC-CHN RC-CHN merged commit 7a519d4 into AstrBotDevs:master May 6, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:provider The bug / feature is about AI Provider, Models, LLM Agent, LLM Agent Runner. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants