test: refactor and enhance P1 platform adapter tests

[whatevertogo]

Refactor and enhance tests for P1 platform adapters (Telegram, Discord, Aiocqhttp) using shared mock utilities to reduce code duplication and improve maintainability.

Modifications / 改动点

• Refactored tests/unit/test_telegram_adapter.py to use shared mocks (~200 lines removed)
• Refactored tests/unit/test_discord_adapter.py to use shared mocks (~120 lines removed)
• Refactored tests/unit/test_aiocqhttp_adapter.py to use shared mocks (~50 lines removed)
• Fixed sender name handling for Discord and Telegram adapters
• Fixed command registration validation in Telegram adapter

Benefits:

• Reduced code duplication by ~370 lines

• Easier to maintain with centralized mock utilities

• Consistent testing patterns across platforms

• This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

# Verification: Telegram adapter tests pass
$ pytest tests/unit/test_telegram_adapter.py -v
...
collected 42 items
..........................................
42 passed in 0.45s

# Verification: Discord adapter tests pass
$ pytest tests/unit/test_discord_adapter.py -v
...
collected 25 items
.........................
25 passed in 0.32s

# Verification: Aiocqhttp adapter tests pass
$ pytest tests/unit/test_aiocqhttp_adapter.py -v
...
collected 18 items
..................
18 passed in 0.28s

---

Checklist / 检查清单

• 😊 如果 PR 中有新加入的功能，已经通过 Issue / 邮件等方式和作者讨论过。/ If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
• 👀 我的更改经过了良好的测试，并已在上方提供了"验证步骤"和"运行截图"。/ My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
• 🤓 我确保没有引入新依赖库，或者引入了新依赖库的同时将其添加到了 requirements.txt 和 pyproject.toml 文件相应位置。/ I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
• 😮 我的更改没有引入恶意代码。/ My changes do not introduce malicious code.

[sourcery-ai]

Sorry @whatevertogo, your pull request is larger than the review limit of 150000 diff characters

[gemini-code-assist]

Summary of Changes

Hello @whatevertogo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the maintainability and reliability of the P1 platform adapters for Telegram, Discord, and Aiocqhttp. The primary focus was on refactoring existing code to reduce duplication, standardizing module imports, and introducing a robust suite of unit tests for each adapter. These changes ensure more consistent behavior across platforms and provide a solid foundation for future development and bug fixes.

Highlights

• Refactored Imports and Module Structure: Imports and module structures were refactored across the aiocqhttp, Discord, and Telegram adapters to enhance consistency and facilitate testing.
• Comprehensive Unit Tests Introduced: New, extensive unit tests were added for aiocqhttp, Discord, and Telegram platform adapters, significantly boosting test coverage and overall reliability.
• Enhanced Command Registration Logic: The command registration logic for Discord and Telegram adapters was improved to correctly handle command aliases, prevent duplicate registrations, and enforce platform-specific naming conventions.
• Fixed Aiocqhttp Image Handling: An issue in the aiocqhttp adapter was resolved where image messages containing only a URL (without a 'file' key) were not parsed correctly.
• Improved Telegram Error Handling: Error handling for Telegram voice message fallback and BadRequest exceptions was refined for better robustness.
• Reduced Code Duplication: Code duplication was reduced by approximately 370 lines across the refactored adapter tests, leading to a more maintainable codebase.

Changelog

• astrbot/core/platform/sources/aiocqhttp/aiocqhttp_message_event.py
  • Updated imports to use aiocqhttp directly and moved MessageChain to astrbot.core.message.message_event_result.
  • Adjusted type hints for bot and event parameters to use aiocqhttp.CQHttp and aiocqhttp.Event.
• astrbot/core/platform/sources/aiocqhttp/aiocqhttp_platform_adapter.py
  • Refactored imports for message components and platform types.
  • Introduced a bot_factory parameter in __init__ and a static _create_bot method to allow mocking aiocqhttp.CQHttp during testing.
  • Added logic to correctly handle image messages that provide a URL but no file data.
  • Updated type hints for convert_message and related methods to use aiocqhttp.Event.
• astrbot/core/platform/sources/discord/discord_platform_adapter.py
  • Refactored _extract_command_info into _extract_command_infos to support extracting multiple command names, including aliases.
  • Added logic to detect and warn about duplicate slash command names during registration.
  • Improved validation for Discord slash command names to ensure they conform to Discord's naming conventions.
• astrbot/core/platform/sources/telegram/tg_adapter.py
  • Refactored imports for telegram.ext and apscheduler.schedulers.asyncio to allow runtime module swapping for testing.
  • Modified command registration logic to prevent clearing existing commands if no new commands are collected.
  • Added warning for duplicate command names during collection and improved command name validation to match Telegram's rules.
  • Updated type hints for message_handler, convert_message, and start methods to use Any for context for broader compatibility.
• astrbot/core/platform/sources/telegram/tg_event.py
  • Updated imports for AstrMessageEvent and MessageChain to their new core locations.
  • Fixed _send_voice_with_fallback to correctly extract the error message from BadRequest exceptions for voice message privacy checks.
• tests/unit/test_aiocqhttp_adapter.py
  • Added new unit tests for the aiocqhttp platform adapter, covering initialization, message conversion, component handling, and adapter lifecycle methods.
• tests/unit/test_discord_adapter.py
  • Added new unit tests for the Discord platform adapter, covering initialization, message conversion, command registration, and various edge cases.
• tests/unit/test_telegram_adapter.py
  • Added new unit tests for the Telegram platform adapter, covering initialization, message conversion, media group handling, command registration, and error handling.

Activity

• Initial commit of refactored adapter code and new unit tests.
• Verification steps were performed, confirming that Telegram, Discord, and Aiocqhttp adapter tests all passed successfully, as evidenced by the provided pytest logs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[dosubot]

Related Documentation

Checked 1 published document(s) in 1 knowledge base(s). No updates required.

^{How did I do? Any feedback?}  

[gemini-code-assist]

Code Review

This pull request is a significant improvement, introducing comprehensive unit tests for the Aiocqhttp, Discord, and Telegram platform adapters. The refactoring for testability, such as using dependency injection and dynamic module imports, is well-executed and will make future development and maintenance much easier. The enhancements to command registration, including alias support for Discord and improved validation for Telegram, are also valuable additions. I've found one minor issue regarding a removed type hint, but overall, this is excellent work that greatly enhances the project's quality and robustness.

[Copilot]

Pull request overview

Refactors and extends unit tests for P1 platform adapters (Telegram, Discord, aiocqhttp/OneBot v11) and makes a few small adapter changes to improve command registration behavior and robustness of message handling.

Changes:

• Refactored/expanded adapter unit tests to use shared helper + mock modules (intended to reduce duplication).
• Improved Telegram command registration (hash-based no-op when unchanged; validation of command names) and hardened Telegram voice fallback error matching.
• Improved Discord slash command registration to expand aliases and ignore duplicates; improved aiocqhttp bot creation testability and image segment URL handling.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tests/unit/test_telegram_adapter.py	Large Telegram adapter/event test suite refactor; now depends on shared tests.fixtures.* helpers/mocks.
tests/unit/test_discord_adapter.py	Discord adapter tests refactor; now depends on shared tests.fixtures.* helpers/mocks.
tests/unit/test_aiocqhttp_adapter.py	aiocqhttp adapter/event tests refactor; now depends on shared tests.fixtures.* helpers/mocks.
astrbot/core/platform/sources/telegram/tg_event.py	Switches to core message/platform imports; hardens voice-fallback error parsing.
astrbot/core/platform/sources/telegram/tg_adapter.py	Runtime-resolves telegram/ext + apscheduler modules for patchability; improves command registration behavior/validation; loosens type annotations for telegram context.
astrbot/core/platform/sources/discord/discord_platform_adapter.py	Collect/register slash commands with alias expansion and duplicate-name suppression; adds command name validation warnings.
astrbot/core/platform/sources/aiocqhttp/aiocqhttp_platform_adapter.py	Adds injectable bot_factory via _create_bot; improves handling of image segments that only contain url.
astrbot/core/platform/sources/aiocqhttp/aiocqhttp_message_event.py	Switches to core imports and aiocqhttp.* type references.

[Dt8333]

有点……小问题？