Skip to content

Conversation

@bananaxiao2333
Copy link

@bananaxiao2333 bananaxiao2333 commented Nov 22, 2025

由原来的第三方PPA安装改为从miniconda安装python

Summary by Sourcery

文档:

  • 在 Termux 部署指南中,将基于 PPA 的 Python 3.10 安装步骤替换为基于 Miniconda 的脚本化安装方案,并针对中国大陆网络环境进行优化。
Original summary in English

Summary by Sourcery

Documentation:

  • Replace PPA-based Python 3.10 installation steps with a scripted Miniconda-based setup optimized for mainland China networks in the Termux deployment guide.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - 我已经审阅了你的改动,这里有一些反馈:

  • 内联安装脚本目前把 aarch64 版的 Miniconda 安装程序(Miniconda3-py310_25.9.1-3-Linux-aarch64.sh)写死在脚本里了。建议要么在文档中说明本指南只适用于 aarch64,要么增加一个简单的架构检测逻辑(例如通过 uname -m),根据架构选择正确的安装程序。
  • 由于脚本会在当前目录写入 install-py310.sh,建议在脚本末尾将其清理掉(rm install-py310.sh),或者在文档中说明会生成这个文件,以便用户知道脚本执行后会留下什么。
  • Miniconda 的下载 URL 目前固定到一个特定版本并使用清华镜像;你可以考虑补充一个简短说明或备用 URL,以便境外用户使用,或者在该版本不再可用时仍有替代方案。
给 AI Agent 的提示
Please address the comments from this code review:

## Overall Comments
- 内联安装脚本目前把 aarch64 版的 Miniconda 安装程序(Miniconda3-py310_25.9.1-3-Linux-aarch64.sh)写死在脚本里了。建议要么在文档中说明本指南只适用于 aarch64,要么增加一个简单的架构检测逻辑(例如通过 uname -m),根据架构选择正确的安装程序。
- 由于脚本会在当前目录写入 install-py310.sh,建议在脚本末尾将其清理掉(rm install-py310.sh),或者在文档中说明会生成这个文件,以便用户知道脚本执行后会留下什么。
- Miniconda 的下载 URL 目前固定到一个特定版本并使用清华镜像;你可以考虑补充一个简短说明或备用 URL,以便境外用户使用,或者在该版本不再可用时仍有替代方案。

Sourcery 对开源项目是免费的——如果你觉得我们的评审有帮助,欢迎分享 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English

Hey there - I've reviewed your changes - here's some feedback:

  • The inline install script hardcodes the aarch64 Miniconda installer (Miniconda3-py310_25.9.1-3-Linux-aarch64.sh), so consider either documenting that this guide only applies to aarch64 or adding simple architecture detection logic (e.g., via uname -m) to pick the correct installer.
  • Since the script writes install-py310.sh into the current directory, it would be helpful to either clean it up at the end (rm install-py310.sh) or mention that this file will be created so users understand what’s left behind.
  • The Miniconda download URL is pinned to a specific version and a Tsinghua mirror; you may want to add a brief note or alternative URL for users outside mainland China or for when this specific version becomes unavailable.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The inline install script hardcodes the aarch64 Miniconda installer (Miniconda3-py310_25.9.1-3-Linux-aarch64.sh), so consider either documenting that this guide only applies to aarch64 or adding simple architecture detection logic (e.g., via uname -m) to pick the correct installer.
- Since the script writes install-py310.sh into the current directory, it would be helpful to either clean it up at the end (rm install-py310.sh) or mention that this file will be created so users understand what’s left behind.
- The Miniconda download URL is pinned to a specific version and a Tsinghua mirror; you may want to add a brief note or alternative URL for users outside mainland China or for when this specific version becomes unavailable.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@bananaxiao2333
Copy link
Author

此PR已被#87 包含

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant