refactor(input): remove falsified gesture experiments - #151
Merged
Conversation
Restore the proven connector path, retain pointer-id normalization and experimental packaging, and preserve the falsification record without shipping the dead experiment machinery. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Refreshes only current-state sections after the v4.1.8 sync, Shift fix, invariant gates, v0.3.0 release and falsified-experiment cleanup. Keeps the older release incidents and v4.1.2 defect investigation as historical context. Records the final post-Shift cleanup baseline (343 tests, four known Windows ParserTest failures), advances the pristine upstream baseline to v4.1.8, and replaces manual fork-invariant greps with the source and packaged-APK gates. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a88bd77f-d993-44c5-9efc-c7124f0d825e
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147.
Outcome
Removes the two-thumb experiments that device testing falsified while preserving the one proven production fix and the reusable side-by-side build infrastructure.
Measured reduction: 22 files changed in the cleanup commit, +245 / -1,721. Relative to the original #141 surface, 13 fewer retained files and 1,484 fewer added lines.
Removed
StrokeAligner/DUAL_POINTERIdealPrefixTrailBuilderThe old connector behavior is restored directly in
WordComposer, with exact connector assertions. The historical document keeps the important falsification: the host-vs-loaded-library boundary, the realambulancenonsense result, and guardrails against repeating the experiment.Kept
PointerIdNormalizer, still wired at fresh-start reset, incremental append and final appendexperimentalbuild type and distinctLeanTypeDual EXPlabel for future controlled experimentsIntegration order
This PR is based directly on final
devafter:The shared Settings/Defaults/SettingsValues/InputLogic/strings surfaces were manually rechecked after the final rebase. The Shift implementation/tests match
devbyte-for-byte and are not part of this diff.Validation
python tools/check_fork_invariants.py— passcompileOfflineRunTestsKotlin— pass:app:testOfflineRunTestsUnitTest --continue --rerun-tasks— 343 tests, 4 known Windows ParserTest failures, 8 skippedtools/check_test_results.py—[ok] no new failures against baseline:app:assembleOfflineExperimental— passStrokeAligner,IdealPrefixTrailBuilder, removed prefs, or the deleted two-pointer harnessNo device was connected. The retained pointer-normalization fix has JVM production-path coverage; hardware smoke remains listed in the refreshed handoff.
Running docs
docs/HANDOFF.mdis refreshed from its stale v0.2.0/v4.0.8 state to v0.3.0/v4.1.8, records the Shift fix and both invariant gates, advances the pristine upstream baseline checkout to v4.1.8, and lists the current device/manual next steps.