PR for NX "preparing models" LP#3277
Conversation
Updated content in the Model Explorer documentation to include an image and clarified the explanation regarding model operations.
…s/model-explorer-ops.png
…s/model-explorer-ops.png
Updated the VGF conversion process and runtime build instructions for clarity and completeness.
Updated title and weight for the Arm tooling section. Added additional context about the Model Gym's utility.
…s/model-explorer-home.PNG
…dels-for-nt/5-convert-to-vgf-and-validate.md
…dels-for-nt/3-extract-tosa-artifacts.md
…dels-for-nt/2-create-reference-model.md
Added a link to download the setup script for easier installation under Python 3.11. Removed the old installation script link.
…dels-for-nt/assests/scripts directory
…dels-for-nt/assets
|
Ready for review. |
annietllnd
left a comment
annietllnd
left a comment
There was a problem hiding this comment.
Thank you Joshua, good stuff! A few nitpicks from me to address :)
| "source": [ | ||
| "## Export with the ExecuTorch VGF backend\n", | ||
| "\n", | ||
| "VGF is the file format we use for NX. through executorch we can lower directly from a pytoch model straigh to a vgf backend model using the direct VGF backend path first. \n", |
There was a problem hiding this comment.
Double check capitalization and spelling here. Capital letter at the beginning of sentence, ExecuTorch, PyTorch, .vgf model (without "backend"). Also, 'straight' lost a t at the end :)
| "id": "2a1e93c7", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Now we will use the model explorer to physicaly view our models. \n", |
There was a problem hiding this comment.
Model Explorer capitalization. Also, remove physically (if you want you can use 'visually' but the sentence stands without it as well). Replace 'we' with 'you'
| "source": [ | ||
| "Now we will use the model explorer to physicaly view our models. \n", | ||
| "\n", | ||
| "This will become incredibly useful later as you use models with much higher complexity " |
There was a problem hiding this comment.
Simplify language: "more complex models"
| "outputs": [], | ||
| "source": [ | ||
| "%%bash\n", | ||
| "# Ensure the vulkan environment variables and MLSDK components are available on $PATH\n", |
There was a problem hiding this comment.
Capitalize Vulkan. Write out the full ML SDK for Vulkan instead of MLSDK
| "source repo/executorch/examples/arm/arm-scratch/setup_path.sh\n", | ||
| "cd repo/executorch/examples/arm\n", | ||
| "\n", | ||
| "# Compiled programs will appear in the executorch/cmake-out directory we create here.\n", |
There was a problem hiding this comment.
remove 'we create here', I find it redundant and we avoid the awkward "you created here" (LPs are written with 'you' instead of 'we')
| "id": "9028535e", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Now that we have built the run time we can use the VKML to simulate our model running on a GPU " |
There was a problem hiding this comment.
Replace with the following: "Now that you've built the runtime you can use the run_vkml.sh script to run the model with it"
While I see your intent, we don't really simulate the running on hardware. It's more a verification of the graph. So let's keep the wording open here.
| "id": "8d4ee8d8", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "If you are happy wih your model you can now use the model converter to turn into a .vgf file or use the executorch path as we did prior. " |
There was a problem hiding this comment.
Capitalize product names: Model Converter, ExecuTorch. Also, replace 'we' with 'you'
|
Changes made in accordance to the changes suggested |
annietllnd
left a comment
annietllnd
left a comment
There was a problem hiding this comment.
All good now, fixed two small ones. This one should be ready for editorial now, I will pass it on. Thank you again for staying on top of this!
4 participants
Before submitting a pull request for a new Learning Path, please review Create a Learning Path
Please do not include any confidential information in your contribution. This includes confidential microarchitecture details and unannounced product information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the Creative Commons Attribution 4.0 International License.