Skip to content

Unit and template tests #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arjun544 merged 16 commits into from
May 23, 2026
Merged

Unit and template tests #40

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
07ab98d
Added drag and drop fonts
Arjun544 May 2, 2026
cd5fca7
feat: implement custom test reporter and establish comprehensive unit…
Arjun544 May 2, 2026
c47bb45
feat: implement tiered CI testing workflows for unit and e2e matrix v…
Arjun544 May 2, 2026
aa4d827
Update lockfile
Arjun544 May 2, 2026
06b62c7
refactor: revert to default vitest reporter and remove custom reporte…
Arjun544 May 2, 2026
2f3efeb
chore: implement CI testing pipeline with matrix-based unit tests, cu…
Arjun544 May 5, 2026
d6960cf
feat: implement handlebars templating engine and matrix-based integra…
Arjun544 May 5, 2026
a3d5ff8
feat: add Handlebars generator utility with custom helpers and config…
Arjun544 May 5, 2026
3dce5ba
feat: implement Flutter project scaffolding engine with template-base…
Arjun544 May 5, 2026
ab8be8a
feat: define application scaffolding schema and add unit tests for co…
Arjun544 May 5, 2026
3009ba9
feat: implement comprehensive matrix-based integration and unit testi…
Arjun544 May 5, 2026
c835c1b
feat: add bun-types and implement automated Dart project validation s…
Arjun544 May 5, 2026
634c213
chore: add bun-types dependency to lockfile
Arjun544 May 5, 2026
a8c5535
removed stats cache
Arjun544 May 22, 2026
4d1fafc
fixed tier 3 test issue
Arjun544 May 22, 2026
6774a45
Merge branch 'main' into unit-and-template-tests
Arjun544 May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-tier3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
- name: Calculate matrix chunks
id: count
run: |
TOTAL=$(bun -e "import { ALL_COMBINATIONS } from './tests/utils/matrix.config'; console.log(ALL_COMBINATIONS.length)")
TOTAL=$(bun -e "import { PRIMARY_COMBINATIONS } from './tests/utils/matrix.config'; console.log(PRIMARY_COMBINATIONS.length)")

@coderabbitai coderabbitai Bot May 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Align matrix chunk sizing with the same combo set used at execution time.

Line 67 computes TOTAL from PRIMARY_COMBINATIONS, but Layer 2 executes and validates ranges against ALL_COMBINATIONS (tests/e2e/run-matrix.ts:38-44, tests/e2e/validate-combo.ts:34-42). This mismatch can silently skip tail combinations when lengths diverge, reducing Tier 3 coverage.

Suggested patch 
-          TOTAL=$(bun -e "import { PRIMARY_COMBINATIONS } from './tests/utils/matrix.config'; console.log(PRIMARY_COMBINATIONS.length)")
+          TOTAL=$(bun -e "import { ALL_COMBINATIONS } from './tests/utils/matrix.config'; console.log(ALL_COMBINATIONS.length)")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
TOTAL=$(bun -e "import { PRIMARY_COMBINATIONS } from './tests/utils/matrix.config'; console.log(PRIMARY_COMBINATIONS.length)")
TOTAL=$(bun -e "import { ALL_COMBINATIONS } from './tests/utils/matrix.config'; console.log(ALL_COMBINATIONS.length)")
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/test-tier3.yml at line 67, The CI step computes TOTAL from
PRIMARY_COMBINATIONS but the runner and validator use ALL_COMBINATIONS, causing
mismatched chunk sizing and skipped tail combos; update the bun command that
sets TOTAL to import and use ALL_COMBINATIONS.length instead of
PRIMARY_COMBINATIONS.length so the matrix chunk sizing aligns with the actual
execution/validation set (reference symbols: TOTAL, PRIMARY_COMBINATIONS,
ALL_COMBINATIONS, and the matrix chunking step).

CHUNK_SIZE=${{ inputs.concurrency || '75' }}
CHUNKS=$(( (TOTAL + CHUNK_SIZE - 1) / CHUNK_SIZE ))

Expand Down
Loading