-
Notifications
You must be signed in to change notification settings - Fork 2
Max dev syscom as installed #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Maxwell2Gyamfi
wants to merge
81
commits into
Apollo-Protocol:main
Choose a base branch
from
Maxwell2Gyamfi:max-dev-syscom-as-installed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Max dev syscom as installed #77
Maxwell2Gyamfi
wants to merge
81
commits into
Apollo-Protocol:main
from
Maxwell2Gyamfi:max-dev-syscom-as-installed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…activities in view
…adjust logic for inactive individuals
…etActivity and Model classes
…ection and display; update HideIndividuals tooltip and button text for clarity; refactor DrawActivities and DrawParticipations for improved rendering; add ArrowUp SVG component.
…nctionality; update DrawParticipations click handlers for better event management; enhance config structure with additional properties for axis and activity labels.
…order radius, and stroke properties; implement color darkening function for improved visual clarity.
…d installations; add entity type selection and parent system dropdown; update Model to manage installations centrally.
…viduals; refactor individual sorting logic and update props for improved rendering and organization.
…n periods; refactor individual sorting logic and update props for improved rendering and organization.
- Cleaned up imports and removed unused components in SetIndividual.tsx. - Improved state management for individual inputs and errors. - Enhanced type handling for individual types and added validation. - Updated the installation handling logic to improve clarity and functionality. - Added new EditInstalledComponent for managing installation periods with a modal interface. - Implemented helper functions for installation references in DrawIndividuals and DrawInstallations. - Improved the drawing logic for installations to handle references correctly. - Updated the Schema to clarify the structure of Individual and Installation interfaces.
…ation periods for effective rendering; refactor individual selection and validation logic for improved accuracy.
…ts' actual installation periods; refactor lane assignment logic for improved rendering of participations.
…Activities, drawIndividuals, drawInstallations, and drawParticipations functions for improved time range handling.
…negative and ending is at least 1
…rticipations; refactor drawing logic for improved rendering accuracy.
…s; refactor element selection in drawing functions for improved robustness.
…cipations; enhance individual deletion logic in Model class to clean up related participations and installations.
…n management and cleanup logic
… improved clarity and organization
…rap for improved entity representation
…l calculation in drawIndividuals; refactor label alignment for consistency
…alculations; add chevrons for nested SystemComponents and installation references
…rove time range handling and segment rect drawing
… improved lane representation
…, NavBar, and DrawActivityDiagram components
- Enhanced SetParticipation component to include all virtual installation rows and filter participants based on activity time. - Introduced helper functions to manage ancestor IDs and check for circular references in installation hierarchies. - Updated DrawActivityDiagram and DrawParticipations to handle nested SystemComponents and InstalledComponents more effectively. - Improved the display logic in DrawIndividuals to account for deeper nesting levels. - Added context handling for installation references in the ID format. - Refined Model class to provide effective time bounds for installation targets and ensure proper display of individuals in the diagram. - Introduced new properties in the Individual interface to support parent path tracking and nesting levels.
…nd adjust icon retrieval logic in DrawIndividuals
…improve installation drawing logic
…ndling and label wrapping for better readability
…ranges and improve label truncation logic
…nd enhance dropdown styling with active link indicators
…tities" for consistency
… and entity types
…lling and installation period visualization
…ActivityDiagram, DiagramLegend, and DiagramPersistence
…ut and scrollable content
…d layout and responsiveness; enhance visibility logic in HideIndividuals
…gramWrap; enhance visibility logic in HideIndividuals
… ExportJson and ExportSvg components for improved code clarity and consistency
…ivityColors props for improved legend rendering
…egends component for enhanced JSON export functionality
…improved user experience
…alability and readability
… Individuals and preserve user-defined order in Model
…oad and save methods to manage localStorage
…mLegend; update ActivityDiagramWrap to manage highlighted activity state
…racking and wrapper height measurement
…cipation rect handling and add bounding box visualization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes Proposed: