fix(schema): export canonical registry proxy - #12
Open
Upd4ting wants to merge 2 commits into
Open
Conversation
Member
Author
|
@greptileai review current HEAD 86dfb2a. Verify all four canonical root declarations (CloseCursor, ReadCursor, RunQuery, Schemas), strict root/subpath identity in both import orders, and provider discovery. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InterfaceDeclarationsnamespaceSchemasexport for existing consumersschema, andqueryimports preserve strict proxy identity in both CommonJS load ordersRoot cause
Core builds provider routes from the canonical interface package root. The published root omitted the internal schema and query proxies, so CMS registrations first failed at
Schemasand then fell back to the CMS provider whenRunQuerywas invoked.Validation
pnpm lintpnpm buildSchemas,RunQuery,ReadCursor, andCloseCursorGreptile Summary
The PR exposes the canonical schema and query declarations through the package root while preserving the direct
Schemasexport.InterfaceDeclarationscontainingCloseCursor,ReadCursor,RunQuery, andSchemas.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Schemasexport using the existing submodule singletons.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Root[Package root] --> Declarations[InterfaceDeclarations] Declarations --> CloseCursor Declarations --> ReadCursor Declarations --> RunQuery Declarations --> Schemas Query[query subpath] --> CloseCursor Query --> ReadCursor Query --> RunQuery Schema[schema subpath] --> Schemas Root -. strict identity .-> Query Root -. strict identity .-> SchemaReviews (2): Last reviewed commit: "fix(database): expose canonical query de..." | Re-trigger Greptile