test: declare table fields with @Field decorator in test fixtures - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Field(...)decorators to the table fixtures inschema.test.tsand the modifier tests (common,encryption,hash,localization)model.test.ts,relation.test.tsandtable.test.tsTest plan
pnpm test→ 96 passing, 0 failinghttps://claude.ai/code/session_016dBZTZJnv6S9vU2jfzeUSK
Greptile Summary
This PR adds
@Field(...)decorators to test fixture classes that were previously missing them inschema.test.tsand the four modifier test files (common,encryption,hash,localization). No test assertions or behavior are changed.@Field(\"string\"),@Field(\"number\"), or@Field(\"any\")above each bare class-field declaration, and update the relevant imports to includeField.@Encrypted→@Field) is consistent with the existing pattern intable.test.ts(@Index→@Field).Confidence Score: 5/5
All changes are confined to test fixtures and add no production logic — safe to merge.
The change is purely additive in test files: it decorates previously bare field declarations with @field(type) and updates the corresponding imports. No assertions, logic, or production code are touched.
No files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["Class field declaration\n(declare / !)"] --> B{"Has domain-specific\ndecorator?"} B -- Yes --> C["@Encrypted / @Hashed\n@Localized / @Index"] B -- No --> D["@Field(type)"] C --> D D --> E["Field registered in\ntable metadata"] E --> F["Tests can assert on\nfield type / behavior"]%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A["Class field declaration\n(declare / !)"] --> B{"Has domain-specific\ndecorator?"} B -- Yes --> C["@Encrypted / @Hashed\n@Localized / @Index"] B -- No --> D["@Field(type)"] C --> D D --> E["Field registered in\ntable metadata"] E --> F["Tests can assert on\nfield type / behavior"]Reviews (1): Last reviewed commit: "test: declare table fields with @Field d..." | Re-trigger Greptile