fix(runtime): export core interface declarations - #11
Merged
Conversation
Member
Author
|
@greptile review |
Member
Author
|
@greptile review |
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Core provider routing discovers proxy identities from each canonical interface package root.
@antelopejs/interface-core@0.0.11exposedGetRuntimeInfo,RegisterDevServer, and the module lifecycle declarations only through subpaths, so consumers received no routes for those proxies even though the Core providers were registered.The root aggregate is safe because it exports the existing canonical declarations; it does not create duplicate proxies. The subpath modules import their constructors from the already-initialized root and the cycle is covered by both source and packed-consumer tests.
Validation
pnpm install --frozen-lockfilepnpm lintpnpm buildpnpm test:packagegit diff --checkRecommended next release: 0.0.12. No merge or publication is performed by this PR.
Greptile Summary
The PR exposes module and runtime declarations from the package root while preserving canonical proxy instances.
InterfaceFunctioninto the cycle-free proxy module.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains; the previously reported import-order cycle is removed by direct proxy-module imports and both loading orders are covered.
Important Files Changed
InterfaceFunctionimplementation.InterfaceFunctiondirectly from the proxy module, avoiding root re-entry.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Root[src/index.ts] --> Modules[src/modules.ts] Root --> Runtime[src/runtime.ts] Root --> Proxies[src/proxies.ts] Modules --> Proxies Runtime --> ProxiesReviews (2): Last reviewed commit: "fix(runtime): remove declaration import ..." | Re-trigger Greptile