-
Notifications
You must be signed in to change notification settings - Fork 0
feat(routes): let a consumer unregister a single route #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| import assert from "node:assert"; | ||
| import { | ||
| getRegisteredRoutes, | ||
| RegisterRoute, | ||
| type RouteHandler, | ||
| routesProxy, | ||
| UnregisterRoute, | ||
| } from "../index"; | ||
|
|
||
| function handlerAt(location: string): RouteHandler { | ||
| return { | ||
| location, | ||
| method: "GET", | ||
| mode: "handler", | ||
| parameters: [], | ||
| properties: {}, | ||
| proto: {}, | ||
| callback: async () => new Response(), | ||
| } as unknown as RouteHandler; | ||
| } | ||
|
|
||
| function routesAt(location: string): number { | ||
| return getRegisteredRoutes().filter((route) => route.location === location) | ||
| .length; | ||
| } | ||
|
|
||
| describe("Route lifecycle", () => { | ||
| // These run against the local build, whose proxy no module attaches in the | ||
| // test harness (the api module binds the harness-distributed copy). A | ||
| // recording provider both keeps the stub-mode proxy from throwing and lets | ||
| // the cases assert what reaches the real registry. | ||
| const proxyCalls: Array<{ kind: "register" | "unregister"; id: string }> = []; | ||
|
|
||
| before(() => { | ||
| routesProxy.onRegister((id: string) => { | ||
| proxyCalls.push({ kind: "register", id }); | ||
| }, true); | ||
| routesProxy.onUnregister((id: string) => { | ||
| proxyCalls.push({ kind: "unregister", id }); | ||
| }); | ||
| }); | ||
|
|
||
| beforeEach(() => { | ||
| proxyCalls.length = 0; | ||
| }); | ||
|
|
||
| it("releases a route by the id RegisterRoute returned", () => { | ||
| const id = RegisterRoute(handlerAt("/lifecycle/released")); | ||
| const bystander = RegisterRoute(handlerAt("/lifecycle/bystander")); | ||
| assert.equal(routesAt("/lifecycle/released"), 1); | ||
|
|
||
| UnregisterRoute(id); | ||
|
|
||
| // Gone from the public listing, and only the targeted route: the | ||
| // bystander keeps serving. | ||
| assert.equal(routesAt("/lifecycle/released"), 0); | ||
| assert.equal(routesAt("/lifecycle/bystander"), 1); | ||
| // The proxy heard the unregister under the id RegisterRoute handed out, | ||
| // as a string — the registry is keyed that way. | ||
| assert.deepEqual(proxyCalls.at(-1), { | ||
| kind: "unregister", | ||
| id: id.toString(), | ||
| }); | ||
| UnregisterRoute(bystander); | ||
| assert.equal(routesAt("/lifecycle/bystander"), 0); | ||
| }); | ||
|
|
||
| it("tolerates unregistering the same id twice", () => { | ||
| const id = RegisterRoute(handlerAt("/lifecycle/twice")); | ||
| UnregisterRoute(id); | ||
|
|
||
| assert.doesNotThrow(() => UnregisterRoute(id)); | ||
| assert.equal(routesAt("/lifecycle/twice"), 0); | ||
| }); | ||
|
|
||
| it("ignores an id that was never registered", () => { | ||
| const before = getRegisteredRoutes().length; | ||
|
|
||
| assert.doesNotThrow(() => UnregisterRoute(999_999)); | ||
|
|
||
| assert.equal(getRegisteredRoutes().length, before); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.