fix: support interface-core 0.0.11 - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Coordinated prerequisite for the Core 1.5 release.
❓ Type of change
📚 Description
Core main at
6712035fb9ecbb924b5916788d9bc50123f77a8adepends on@antelopejs/interface-core@^0.0.11. The published API 1.2.2 manifest depends on^0.0.6, so Core rejects the module graph before construction because 0.0.11 does not satisfy that range.This PR:
^0.0.6to>=0.0.6 <1.0.0;internal.routesProxyas well asroutesProxy;ImplementInterface.@antelopejs/interface-apihas declared both proxy paths throughout the supported range, while the provider only exposed the root path. Both names now reference the same existing handler object, so no request-path logic changes.The regression test runs the locked interface packages and built provider in a clean Node process because the Core 1.4.7 test runner intentionally redirects bare interface imports to its own dependency graph. Removing
internal.routesProxymakes this test fail withMissing or malformed interface handler at implementation.internal.routesProxy; restoring the alias makes the targeted and complete suites pass.Before / after
^0.0.6>=0.0.6 <1.0.0implementation.internal.routesProxyCompatibility matrix
[ERROR]lines6712035fb9ecbb924b5916788d9bc50123f77a8aGET /health→ 200application/json,{"status":"ok","core":"6712035"}@antelopejs/core@1.4.7GET /health→ 200application/json,{"status":"ok","core":"1.4.7"}Validation
pnpm install --frozen-lockfile— passpnpm run lint— passpnpm run build— passcontroller-resolution.test.js— pass, 6 testsimplementation.internal.routesProxypnpm run test— pass, 164 testspnpm pack— pass, 57 files, 48,297 bytes, SHA-25676266a7ae8d93cde1fddabcce96e2778dce8bc879a02ecbde446175eedd272bbpackage/package.json— verified@antelopejs/interface-core: ">=0.0.6 <1.0.0"pnpm publish --dry-run --no-git-checks— pass, public@antelopejs/api@1.2.2preview with 57 filesThe test suite intentionally emits error logs while asserting 500/error behavior; the command exits successfully with 164 passing tests.
Limits
GetRuntimeInfoandRegisterDevServerhave no routed provider for the API module at those call sites. There are no[ERROR]lines, startup completes, and the real HTTP request succeeds.Release order
📝 Checklist