Skip to content

perf(api): compile request controller resolution #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Upd4ting merged 1 commit into from
Aug 19, 2026
Merged

perf(api): compile request controller resolution #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
232 changes: 185 additions & 47 deletions src/implementations/api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {
type ComputedParameter,
ControllerMeta,
type CorsConfig,
computeParameter,
type RouteHandler,
} from "@antelopejs/interface-api";
import { GetMetadata } from "@antelopejs/interface-core";
Expand All @@ -24,8 +23,31 @@ interface ControllerMetadata {
computed_props: Record<PropertyKey, ComputedParameter>;
}

type ParameterResolver = (
context: RequestContextDev,
controllerInstance: UnknownRecord,
) => unknown;

interface ComputedPropertyResolver {
key: string;
resolve: ParameterResolver;
}

interface ControllerPlan {
controllerClass: ControllerClass;
cacheKey: object;
computedProperties: ComputedPropertyResolver[];
}

interface HandlerPlan {
callback: RouteHandler["callback"];
controller: ControllerPlan;
parameters: ParameterResolver[];
}

const classCacheSymbol = Symbol();
const registeredRoutes = new Map<string, RouteHandler>();
const controllerPlans = new WeakMap<ControllerClass, ControllerPlan>();

interface RequestContextDev extends RequestContext {
[classCacheSymbol]?: Map<object, unknown>;
Expand All @@ -39,56 +61,137 @@ function getControllerCache(context: RequestContextDev): Map<object, unknown> {
return context[classCacheSymbol];
}

async function applyComputedProperties(
function compileParameter(
parameter: ComputedParameter | null,
): ParameterResolver {
if (!parameter?.provider) {
return () => undefined;
}

const { provider } = parameter;
const modifiers = [...parameter.modifiers];
if (modifiers.length === 0) {
return (context, controller) => provider.call(controller, context);
}

return async (context, controller) => {
let value = await provider.call(controller, context);
for (const modifier of modifiers) {
value = await modifier.call(controller, context, value);
}
return value;
};
}

function compileController(
controllerClass: ControllerClass,
properties: Record<PropertyKey, ComputedParameter>,
): ControllerPlan {
const computedProperties = Object.entries(properties).map(
([key, parameter]) => ({
key,
resolve: compileParameter(parameter),
}),
);
const existingPlan = controllerPlans.get(controllerClass);
const plan = existingPlan ?? {
controllerClass,
cacheKey: controllerClass.prototype,
computedProperties,
};
plan.computedProperties = computedProperties;
controllerPlans.set(controllerClass, plan);
return plan;
}

function getControllerPlan(controllerClass: ControllerClass): ControllerPlan {
const cachedPlan = controllerPlans.get(controllerClass);
if (cachedPlan) {
return cachedPlan;
}

const metadata = GetMetadata(
controllerClass,
ControllerMeta,
) as ControllerMetadata;
return compileController(controllerClass, metadata.computed_props);
}

function isPromiseLike(value: unknown): value is PromiseLike<unknown> {
return (
value !== null &&
(typeof value === "object" || typeof value === "function") &&
"then" in value &&
typeof value.then === "function"
);
}

function applyComputedProperties(
controllerInstance: UnknownRecord,
controllerMetadata: ControllerMetadata,
computedProperties: ComputedPropertyResolver[],
context: RequestContextDev,
): Promise<void> {
await Promise.all(
Object.entries(controllerMetadata.computed_props).map(
async ([propertyKey, parameter]) => {
const computedValue = await computeParameter(
context,
parameter,
controllerInstance,
);
controllerInstance[propertyKey] = computedValue;
},
),
);
): void | Promise<void> {
if (computedProperties.length === 0) {
return;
}

const pending: Promise<void>[] = [];
for (const property of computedProperties) {
const value = property.resolve(context, controllerInstance);
if (isPromiseLike(value)) {
pending.push(
Promise.resolve(value).then((resolved) => {
controllerInstance[property.key] = resolved;
}),
);
} else {
controllerInstance[property.key] = value;
}
}

if (pending.length > 0) {
return Promise.all(pending).then(() => undefined);
}
}

export async function GetControllerInstance(
controllerClass: Class<unknown>,
context: RequestContext,
): Promise<unknown> {
const controllerCache = getControllerCache(context as RequestContextDev);
const cacheKey = controllerClass.prototype;
const cachedController = controllerCache.get(cacheKey) as
function resolveControllerInstance(
plan: ControllerPlan,
context: RequestContextDev,
): UnknownRecord | Promise<UnknownRecord> {
const controllerCache = getControllerCache(context);
const cachedController = controllerCache.get(plan.cacheKey) as
| UnknownRecord
| undefined;

if (cachedController) {
return cachedController;
}

const typedControllerClass = controllerClass as ControllerClass;
const controllerInstance = new typedControllerClass() as UnknownRecord;
const controllerMetadata = GetMetadata(
typedControllerClass,
ControllerMeta,
) as ControllerMetadata;

await applyComputedProperties(
const controllerInstance = new plan.controllerClass() as UnknownRecord;
const computed = applyComputedProperties(
controllerInstance,
controllerMetadata,
context as RequestContextDev,
plan.computedProperties,
context,
);
if (computed) {
return computed.then(() => {
controllerCache.set(plan.cacheKey, controllerInstance);
return controllerInstance;
});
}

controllerCache.set(cacheKey, controllerInstance);
controllerCache.set(plan.cacheKey, controllerInstance);
return controllerInstance;
}

export async function GetControllerInstance(
controllerClass: Class<unknown>,
context: RequestContext,
): Promise<unknown> {
const plan = getControllerPlan(controllerClass as ControllerClass);
return resolveControllerInstance(plan, context as RequestContextDev);
}

export async function Listen(): Promise<void> {
await listenServers();
}
Expand All @@ -110,32 +213,67 @@ interface RouteInfo {
callbackName: string;
}

async function invokeHandler(
handler: RouteHandler,
function invokeCallback(
plan: HandlerPlan,
controllerInstance: UnknownRecord,
context: RequestContextDev,
): Promise<unknown> {
const controllerClass = handler.proto.constructor as ControllerClass;
const controllerInstance = await GetControllerInstance(
controllerClass,
context,
): unknown {
if (plan.parameters.length === 0) {
return plan.callback.call(controllerInstance);
}
if (plan.parameters.length === 1) {
const parameter = plan.parameters[0](context, controllerInstance);
if (isPromiseLike(parameter)) {
return Promise.resolve(parameter).then((resolved) =>
plan.callback.call(controllerInstance, resolved),
);
}
return plan.callback.call(controllerInstance, parameter);
}

const parameters = plan.parameters.map((resolve) =>
resolve(context, controllerInstance),
);
const resolvedParameters = await Promise.all(
handler.parameters.map((parameter) =>
computeParameter(context, parameter, controllerInstance),
),
if (parameters.some(isPromiseLike)) {
return Promise.all(parameters).then((resolved) =>
plan.callback.apply(controllerInstance, resolved),
);
}
return plan.callback.apply(controllerInstance, parameters);
}

function invokeHandler(plan: HandlerPlan, context: RequestContextDev): unknown {
const controllerInstance = resolveControllerInstance(
plan.controller,
context,
);
return handler.callback.apply(controllerInstance, resolvedParameters);
if (isPromiseLike(controllerInstance)) {
return Promise.resolve(controllerInstance).then((resolved) =>
invokeCallback(plan, resolved, context),
);
}
return invokeCallback(plan, controllerInstance, context);
}

function compileHandler(handler: RouteHandler): HandlerPlan {
const controllerClass = handler.proto.constructor as ControllerClass;
return {
callback: handler.callback,
controller: compileController(controllerClass, handler.properties),
parameters: handler.parameters.map(compileParameter),
};
}

export const routesProxy = {
register: (id: string, handler: RouteHandler): void => {
registeredRoutes.set(id, handler);
const plan = compileHandler(handler);
registerHandler(
`dev/${id}`,
handler.mode,
handler.method,
handler.location,
async (context: RequestContextDev) => invokeHandler(handler, context),
(context: RequestContextDev) => invokeHandler(plan, context),
handler.priority,
);
},
Expand Down
Loading
Loading