chore(deps): let the interface range reach UnregisterRoute - #28
Merged
Conversation
The interface dependency read ^0.0.8, and an npm caret on a 0.0.x version pins that exact patch: nothing depending on this module could ever see interface-api 0.0.10, where UnregisterRoute ships. The AntelopeJS loader hands every module the implementor's interface copy, so the pin here decided for the whole deployment. Widen to >=0.0.10 <1.0.0, the same shape consumers already use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface dependency read
^0.0.8— and an npm caret on a0.0.xversion pins that exact patch (>=0.0.8 <0.0.9). Nothing depending on this module could ever resolve interface-api 0.0.10, whereUnregisterRoute(AntelopeJS/interface-api#13) ships.This matters beyond this package: the AntelopeJS loader hands every module of a deployment the implementor's interface copy. The pin here therefore decided the interface version for every consumer — the CMS page teardown calls
UnregisterRouteand gotTypeError: not a functionin any environment where this module supplies the interface.Widened to
>=0.0.10 <1.0.0, the range shape consumers already use for 0.x interfaces. Lockfile resolves 0.0.10; 120 tests passing.Consumer waiting on this: the CMS
fix/release-page-routebranch, which releases a page's own layout route on unregistration — the last registry its teardown did not reclaim.Greptile Summary
Updates
@antelopejs/interface-apiso consumers can resolve theUnregisterRouteAPI introduced in version 0.0.10.^0.0.8to>=0.0.10 <1.0.0.Confidence Score: 5/5
The PR appears safe to merge, with the manifest and lockfile consistently enabling interface-api 0.0.10.
The dependency range now reaches the required interface release, and the lockfile consistently resolves the root package and interface utility against version 0.0.10 without an identified current failure.
Important Files Changed
Reviews (1): Last reviewed commit: "chore(deps): let the interface range rea..." | Re-trigger Greptile