Fix event args generation for FileSystemWatcher of the WatchingResolvePathTemplateManager#537
Open
Lunatic174 wants to merge 1 commit intoAntaris:masterfrom
Open
Fix event args generation for FileSystemWatcher of the WatchingResolvePathTemplateManager#537Lunatic174 wants to merge 1 commit intoAntaris:masterfrom
Lunatic174 wants to merge 1 commit intoAntaris:masterfrom
Conversation
…ePathTemplateManager The FileSystemEventArgs takes as argument directory path, not the full path to the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FileSystemEventArgs takes as argument the directory path, not the full path to the file:
https://docs.microsoft.com/en-us/dotnet/api/system.io.filesystemeventargs.-ctor?view=netframework-4.7.2
I tried to use WatchingResolvePathTemplateManager for debugging, but when you change template in Visual Studio it actually fires 7 events, for example (not exactly in that order):
So if we are looking for DirectoryPath\Filename.cshtml, it will be mentioned only in 'Renamed' event.
But it was not working correctly, because of wrong FileEventArgs parameters.