fixed issue with Assembly.Location throwing

[defr0zen]

Assembly.Location could throw. In my case, I am trying to use RazorEngine in an Azure Function, which loads some native Edge dlls for JavaScript interop. These assemblies are loaded into the domain, however, calling Assembly.Location on them throws an exception.

I was thinking to use a custom resolver, however, this code is also used in the exceptions, and it is not trivial to use the custom resolver in the exception constructors. Hence such quick fix.

[matthid]

Sorry for the late review, one smaller thing to change.

[matthid]

Can you clarify which exception is thrown and only catch the specific one (and add a comment)?
Otherwise (if we want to catch all) we need some kind of logging here at the very least.

[vovikdrg]

In AF this part is throwing exception.

[shyamal890]

Guys any temp workaround till the time this pull is merged into the master?

[matthid]

@shyamal890 Yes the assembly-resolver can be configured so you can just copy it to your code and configure it.

[shyamal890]

@matthid I created a new cs file with the following code. However, CompilerServiceBase.DynamicTemplateNamespace gives an error since it's inaccessible due to its protection level.

namespace RazorEngine.Compilation.ReferenceResolver
{
    public class UseCurrentAssembliesReferenceResolver : IReferenceResolver
    {
        /// <summary>
        /// See <see cref="IReferenceResolver.GetReferences"/>
        /// </summary>
        /// <param name="context"></param>
        /// <param name="includeAssemblies"></param>
        /// <returns></returns>
        public IEnumerable<CompilerReference> GetReferences(TypeContext context = null, IEnumerable<CompilerReference> includeAssemblies = null)
        {
            return CompilerServicesUtility
                   .GetLoadedAssemblies()
                   .Where(IsValidAssembly)
                   .GroupBy(a => a.GetName().Name).Select(grp => grp.First(y => y.GetName().Version == grp.Max(x => x.GetName().Version))) // only select distinct assemblies based on FullName to avoid loading duplicate assemblies
                   .Select(a => CompilerReference.From(a))
                   .Concat(includeAssemblies ?? Enumerable.Empty<CompilerReference>());
        }

        private static bool IsValidAssembly(System.Reflection.Assembly a)
        {
            try
            {
                return !a.IsDynamic && File.Exists(a.Location) && !a.Location.Contains(CompilerServiceBase.DynamicTemplateNamespace);
            }
            catch
            {
                return false;
            }
        }

    }
}

[matthid]

@shyamal890

RazorEngine/src/source/RazorEngine.Core/Compilation/CompilerServiceBase.cs

Line 34 in a2a17c5

protected internal const string DynamicTemplateNamespace = "CompiledRazorTemplates.Dynamic";

[harmandeol]

when will this be merged?

[vovikdrg]

private static bool IsValidAssembly(System.Reflection.Assembly a)
        {
            //Azure function is failing when try to accessl location of this dll
            var skipByName = new[] {"edge_nativeclr"};
            return !skipByName.All(c => a.FullName.StartsWith(c)) && !a.IsDynamic && File.Exists(a.Location) &&
                   !a.Location.Contains(DynamicTemplateNamespace);
        }

Basiclly this fixes my problem