Conversation
|
I actually think this needs to be changed everywhere. msgs->emails, Message->Email, etc. Consistency seems helpful. WDYT? |
|
bumping this @ncoop57 |
|
sorry, just saw the comment. Will make the change, thanks @jph00 |
| @@ -1,5 +1,5 @@ | |||
| import time,uuid,pytest | |||
| from fastcore.test import test_eq,test,ne | |||
| from fastcore.test import test_eq as eq, test as check | |||
There was a problem hiding this comment.
Why this change btw? eq normally is fastcore's eq() function or python's operator.eq() - having it as test_eq is kinda confusing IMO. And we use test() quite a bit so renaming it is also confusing!
There was a problem hiding this comment.
codex got carried away. Reverting these
There was a problem hiding this comment.
codex did it as it said that pytest was thinking they were things that needed testing hehe
|
What's needed to move this out of draft @ncoop57 ? |
|
@jph00 should be ready now. Sorry for the delay |
|
@jph00 merged the audit updates, so should be good to go |
|
Many thanks |
2 participants
Renames
view_msg()andview_msgs()toview_email()andview_emails()forbetter API consistency and clarity.
This improves the API naming convention to use the more standard 'email' terminology throughout.