Make execnb an optional fill extra - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execnb(and the IPython tree it brings) now installs only withpip install 'mdhtml[fill]'. It was a hard dependency used in exactly one place: the shell that executes{python}blocks for fillmd. The import is now lazy, soimport mdhtmlnever loads IPython, and a bare install that reaches an executable block gets an ImportError naming the extra. A test pins the bare import to stay execnb-free, and the fillmd section of the README documents the extra.Also aligns the conformance fixtures with the dialect decisions that only a bare
---is a thematic break and that setext headings don't exist: 27 cmark spec examples are taggeddisabled, and the PHP Markdown Extra fixtures use---separators, with the headers-with-attributes expectations keeping------underlines as paragraph text.