Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Comments

First Commit#2

Open
AndreiGrek wants to merge 1 commit intomasterfrom
Homework3
Open

First Commit#2
AndreiGrek wants to merge 1 commit intomasterfrom
Homework3

Conversation

@AndreiGrek
Copy link
Owner

No description provided.

android:layout_height="match_parent"
android:orientation="vertical">

<LinearLayout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для LinearLayout нужно еще дописывать orientation

android:textSize="25sp" />
</LinearLayout>

<LinearLayout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для LinearLayout нужно еще дописывать orientation

android:textSize="25sp" />
</LinearLayout>

<LinearLayout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для LinearLayout нужно еще дописывать orientation

android:text="Education"
android:textSize="25sp" />
</LinearLayout>
<LinearLayout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для LinearLayout нужно еще дописывать orientation

android:text="Family"
android:textSize="25sp" />
</LinearLayout>
<LinearLayout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для LinearLayout нужно еще дописывать orientation

android:text="Health"
android:textSize="25sp" />
</LinearLayout>
<LinearLayout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для LinearLayout нужно еще дописывать orientation

android:text="Office"
android:textSize="25sp" />
</LinearLayout>
<LinearLayout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для LinearLayout нужно еще дописывать orientation

android:text="Promotions"
android:textSize="25sp" />
</LinearLayout>
<LinearLayout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для LinearLayout нужно еще дописывать orientation

android:text="Radio"
android:textSize="25sp" />
</LinearLayout>
<LinearLayout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для LinearLayout нужно еще дописывать orientation

android:text="Recipes"
android:textSize="25sp" />
</LinearLayout>
<LinearLayout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для LinearLayout нужно еще дописывать orientation

Comment on lines +6 to +7


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Старайся не оставлять пустые строки

android:layout_gravity="right"
android:text="Weight"
android:layout_marginTop="10dp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лишняя путсая строка

android:textColor="#000000"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintLeft_toLeftOf="parent">
</TextView>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</TextView>тут лишний. Когда у тебя одиночный элемент, который не включает в себя что-то другое, то можно написать вот так: />

В итоге у тебя будет вот так

<TextView
        android:id="@+id/text1"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Sign In"
        android:textSize="40sp"
        android:layout_marginTop="30dp"
        android:layout_marginLeft="20dp"
        android:textColor="#000000"
        app:layout_constraintTop_toTopOf="parent"
        app:layout_constraintLeft_toLeftOf="parent"/>

Comment on lines +54 to +55


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

пустые строки

Comment on lines +68 to +71
<Space
android:id="@+id/space"
android:layout_width="0dp"
android:layout_height="250dp"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Обычно Space используют только ждля заполнения пустого пространства, например, при использовании веса. Тут же можно обойтись просто отступом сверху для кнопки

android:layout_marginTop="30dp"
android:layout_marginLeft="20dp"
android:textColor="#000000">
</TextView>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</TextView>тут лишний. Когда у тебя одиночный элемент, который не включает в себя что-то другое, то можно написать вот так: />

В итоге у тебя будет вот так

<TextView
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Sign In"
        android:textSize="40sp"
        android:layout_marginTop="30dp"
        android:layout_marginLeft="20dp"
        android:textColor="#000000"/>

android:layout_marginTop="30dp"
android:layout_marginLeft="20dp"
android:textColor="#000000">
</TextView>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тот же коммент

Comment on lines +15 to +17



Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не оставляй столько пустых строк. везде должен быть порядок

android:layout_marginTop="10dp"
android:layout_below="@id/adress"
android:background="#5C4E4E"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

перенеси закрывающий оператор на строку выше

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants