This repository was archived by the owner on Nov 30, 2021. It is now read-only.
Open
Conversation
Comment on lines
+53
to
+57
| default: | ||
| throw new IllegalArgumentException | ||
| ("Unknown URI: " + uri); | ||
|
|
||
| } |
There was a problem hiding this comment.
Прокидывать Exception тут не самая лучшая идея, тубу так или иначе нужно вернуть результат. Пусть это будет null, но это так или иначе результат
Comment on lines
+64
to
+78
| switch (uriMatcher.match(uri)) { | ||
| case ID_PERSON_DATA: | ||
| throw new IllegalArgumentException | ||
| ("Invalid uri: cannot delete"); | ||
| case ID_PERSON_DATA_ITEM: | ||
| if (getContext() != null) { | ||
| int count = contactDao | ||
| .delete(ContentUris.parseId(uri)); | ||
| getContext().getContentResolver() | ||
| .notifyChange(uri, null); | ||
| return count; | ||
| } | ||
| default: | ||
| throw new IllegalArgumentException | ||
| ("Unknown URI:" + uri); |
There was a problem hiding this comment.
Прокидывать Exception тут не самая лучшая идея, тубу так или иначе нужно вернуть результат. Пусть это будет -1, но это так или иначе результат
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.