Add ST7735 support #149
Open
Add ST7735 support #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodakjerec
commented
Dec 27, 2022
kodakjerec
commented
- Add ST7735 support. copy from ILI9341.
- Change setRotation(m) definition.
- Add setResolution(width, height). In order to support different size lcd.
- Add ST7735 example. copy from ILI9341, and add function setResolution().
2. Change setRotation(m) definition. 3. Add setResolution(width, height). In order to support different size lcd. 4. Add ST7735 example. copy from ILI9341.
Contributor
|
Hi @kodakjerec, I'm currently testing this code with the hardware right now, want to check with you if you have this issue as well? It seems like the drawing area is offset from the actual screen area, a fill screen function does not fill the LCD completely. Also, would like to check with you if this is the same hardware you are using? Thank you.
|
Author
|
Dear:
Thank you for your response!
I am using a 1.8-inch ST7735
This is a product picture, and I don't have the machine at this moment.
***@***.***
I have kept the option to switch the resolution in the following path. It’s an example code.
Comment out line 31 and uncomment line 33, and it should display properly.
ambd_arduino/Arduino_package/hardware/libraries/SPI/examples/ST7735_TFT_LCD_basic/ST7735_TFT_LCD_basic.ino
***@***.***
The source code has added a method to switch the resolution, and original IL9341 must be modified in .h file.
ambd_arduino/Arduino_package/hardware/libraries/SPI/src/AmebaST7735.cpp
***@***.***
I hope this modification can make it easy for users to switch the resolution. If it is still not working, I will find another board with the same size to test it.
From: Daphne ***@***.***>
Sent: Monday, February 13, 2023 3:05 PM
To: ambiot/ambd_arduino ***@***.***>
Cc: kodak ***@***.***>; Mention ***@***.***>
Subject: Re: [ambiot/ambd_arduino] Add ST7735 support (PR #149)
Hi @kodakjerec<https://github.com/kodakjerec>,
I'm currently testing this code with the hardware right now, want to check with you if you have this issue as well? It seems like the drawing area is offset from the actual screen area, a fill screen function does not fill the LCD completely.
[IMG_2185]<https://user-images.githubusercontent.com/72006538/218391203-36d40ab0-8142-49b1-b3de-6a2807c78228.JPG>
Also, would like to check with you if this is the same hardware you are using? Thank you.
[IMG_2186]<https://user-images.githubusercontent.com/72006538/218392381-65441af2-9398-477b-bacf-bdddac075111.JPG>
—
Reply to this email directly, view it on GitHub<#149 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADE2FZ4MBQWG2JTG4YCM3A3WXHMKJANCNFSM6AAAAAATKFZZE4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Contributor
|
Hi @kodakjerec, Thanks for your reply! The picture that i have shown with the blue not completely filled is after i have comment out line 31 and uncomment line 33. So would need your help to test and check if you have the same issue. Thank you. |
Author
|
Dear:
(sigh)I need to buy a new 0.96inch board.
The following test results are for 1.8 inches, not 0.96 inches.
Attachments is assumed 0.96 inch wiring diagram(fritzing file). For the 1.8 inch, I followed the same connections.
The .ino file has also been modified.
When rotating test, the pattern will not fit perfectly to the screen because of different resolution.
***@***.******@***.******@***.***
Fritzing png
***@***.***
From: Daphne ***@***.***>
Sent: Tuesday, February 14, 2023 10:05 AM
To: ambiot/ambd_arduino ***@***.***>
Cc: kodak ***@***.***>; Mention ***@***.***>
Subject: Re: [ambiot/ambd_arduino] Add ST7735 support (PR #149)
Hi @kodakjerec<https://github.com/kodakjerec>,
Thanks for your reply! The picture that i have shown with the blue not completely filled is after i have comment out line 31 and uncomment line 33. So would need your help to test and check if you have the same issue. Thank you.
—
Reply to this email directly, view it on GitHub<#149 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADE2FZY4VGPUD4ZZUTZQQP3WXLR55ANCNFSM6AAAAAATKFZZE4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Author
|
I tested 0.96inch 1.44inch
same circuit and code
It can display, but the image is displaced. I need more time to correct it
取得 Android 版 Outlook<https://aka.ms/AAb9ysg>
…________________________________
From: 簡 克達
Sent: Wednesday, February 15, 2023 12:03:03 PM
To: ambiot/ambd_arduino ***@***.***>; ambiot/ambd_arduino ***@***.***>
Cc: Mention ***@***.***>
Subject: RE: [ambiot/ambd_arduino] Add ST7735 support (PR #149)
Dear:
(sigh)I need to buy a new 0.96inch board.
The following test results are for 1.8 inches, not 0.96 inches.
Attachments is assumed 0.96 inch wiring diagram(fritzing file). For the 1.8 inch, I followed the same connections.
The .ino file has also been modified.
When rotating test, the pattern will not fit perfectly to the screen because of different resolution.
***@***.******@***.******@***.***
Fritzing png
***@***.***
From: Daphne ***@***.***>
Sent: Tuesday, February 14, 2023 10:05 AM
To: ambiot/ambd_arduino ***@***.***>
Cc: kodak ***@***.***>; Mention ***@***.***>
Subject: Re: [ambiot/ambd_arduino] Add ST7735 support (PR #149)
Hi @kodakjerec<https://github.com/kodakjerec>,
Thanks for your reply! The picture that i have shown with the blue not completely filled is after i have comment out line 31 and uncomment line 33. So would need your help to test and check if you have the same issue. Thank you.
—
Reply to this email directly, view it on GitHub<#149 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADE2FZY4VGPUD4ZZUTZQQP3WXLR55ANCNFSM6AAAAAATKFZZE4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
|
This pull request is stale because there is no activity for 14 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.