fix: fixed missing rowsBefore in summeray2#4204
Conversation
📝 WalkthroughWalkthroughThis PR extends ChangesRepeatingGroup table summary before/after rows
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Magnusrm
left a comment
There was a problem hiding this comment.
It seems like the rowsbefore should come before the header in the summary like it does for the regular component.
Also it seems like the rows are missing a cell in order to take up as mnuch space as the regular rows which contain an edit button. There is logic for this in the Grid components summary2, where the row gets an edit button if the row contains a form component (editable component), and an empty cell if it contains no form components.




Description
Before:
After:
Related Issue(s)
rowsBeforeis missing from Summary2 #4188Verification/QA
kind/*andbackport*label to this PR for proper release notes grouping