Fips 140 autotests#1443
Draft
besteffects wants to merge 22 commits into
Draft
Conversation
besteffects
commented
Jun 29, 2026
besteffects
commented
Member
- Improved fips_140_3 tests readability
- Assigned correct test steps
- Improved asserts, removed unneded ones
- Fixed links in test documentation
- Adjusted test step descriptions
Slach
requested changes
Jul 1, 2026
Keeper (Coordination) "Operation timeout" (Code: 999) failures — like the DROP DATABASE ON CLUSTER in TestSkipTablesAndSkipTableEngines — were hard to diagnose because the failure dumps only ever covered the clickhouse container, never its keeper, and ExitCode/OOMKilled are read after Docker has already auto-restarted the crashed container (so they read as running/0/false). - containerStateSummary(): shared state banner that also reports RestartCount, the only signal that survives an auto-restart. - Dump the zookeeper (keeper) container alongside clickhouse on query failure (queryWithNoError), on DROP DATABASE failure (dropDatabase), and when clickhouse fails its health check (waitHealthy).
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # test/integration/containers.go
Member
Author
|
@Slach This pull request has some merge conflicts with integration tests. |
Collaborator
|
@besteffects i will resolve conflicts from my side |
…ips_140_autotests # Conflicts: # test/integration/containers.go # test/integration/utils.go
…0_autotests # Conflicts: # test/integration/containers.go # test/integration/utils.go
Collaborator
|
@besteffects please make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.