Skip to content

Add case for Numeric values. Redo example to work without external UDF#174

Merged
shacuros merged 2 commits intoAltinity:mainfrom
shacuros:migrate_uniqExact
Mar 26, 2026
Merged

Add case for Numeric values. Redo example to work without external UDF#174
shacuros merged 2 commits intoAltinity:mainfrom
shacuros:migrate_uniqExact

Conversation

@shacuros
Copy link
Contributor

@shacuros shacuros commented Mar 25, 2026

The case for Numeric values was missing. It can use different logic.

Added some more sections to make it more readable

Changed logic for the example to use ClickHouse internal functions, so it can work on cloud installations as well

I have read the CLA Document and I hereby sign the CLA

The case for Numeric values was missing. It can use different logic.

Added some more secionts to make it more readable

Changed logic for the example to use ClickHouse internal functions, so it can work on cloud installations as well
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@shacuros
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Mar 25, 2026
@shacuros shacuros requested a review from lesandie March 25, 2026 12:57
Fixed typo and two following howevers
@shacuros shacuros self-assigned this Mar 25, 2026
Copy link
Member

@lesandie lesandie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UnamedRus
Copy link
Contributor

LGTM,
Btw in 26.3, with WASM UDF support it's possible to deploy simple function just using SQL, so should work in clouds as well.

@shacuros
Copy link
Contributor Author

Good to know Dima, that would make a few things easier in the future definitelly :)

Thx guys

@shacuros shacuros merged commit 0dcbefd into Altinity:main Mar 26, 2026
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2026
@shacuros shacuros deleted the migrate_uniqExact branch March 26, 2026 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants