Repository navigation
Conversation
DataLakeCatalog builds a fresh storage on every lookup, so object_storage_cluster file listing ran before the snapshot was loaded and threw "Metadata is not initialized". Co-authored-by: Cursor <cursoragent@cursor.com>
…e_cluster. Alias, Buffer, Merge, materialized views, loop, and Distributed all resolve a fresh catalog storage, so each one is checked the same way for local, query, and database cluster settings. Co-authored-by: Cursor <cursoragent@cursor.com>
The customer filter, limit, and count checks now run against the REST catalog and cluster_simple, including parallel replicas, so the stateless REST stub is no longer needed. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ianton-ru
added
antalya
bugfix
port-antalya
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e85333854
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Customer repro moved from the stateless suite. An Alias over a catalog Iceberg | ||
| table must apply the same filter as a direct catalog read: local, with | ||
| object_storage_cluster, and with parallel replicas. count() is the path that | ||
| already succeeded before snapshot initialization on the cluster file listing. |
There was a problem hiding this comment.
These new docstrings use literal SQL engine and setting names as plain prose—for example, Alias, Iceberg, and object_storage_cluster—while repository guidance requires ClickHouse language names in comments and documentation to be formatted as inline code; apply that formatting throughout both added docstrings.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
Related: #2550 Co-authored-by: Cursor <cursoragent@cursor.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15eceeb40b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| **table_settings, | ||
| "object_storage_cluster": "cluster_simple", | ||
| } | ||
| # A clustered Buffer destination reports WithMergeableState, so Buffer plans |
There was a problem hiding this comment.
The newly added comment leaves the literal Buffer engine and WithMergeableState stage name as plain prose. Wrap these names in backticks to follow the repository requirement for ClickHouse SQL and class names in comments.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
Related: #2550 Co-authored-by: Cursor <cursoragent@cursor.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
`StorageSnapshot` only referenced the target, and `DataLakeCatalog` drops that storage when `getStorageSnapshot` returns. The analyzer then read freed memory under ASan. https: //altinity-build-artifacts.s3.amazonaws.com/json.html?PR=2550&sha=2a09ee317a90d65f72165bbb9f1c4d407ec41c48&name_0=PR&name_1=Integration%20tests%20%28amd_asan_ubsan%2C%20db%20disk%2C%20old%20analyzer%2C%208%2F8%29 Related: #2550 Co-authored-by: Cursor <cursoragent@cursor.com>
This reverts commit abc516e.
|
This PR requires #2557 to be merged as well for the issue to be properly solved. |
This branch has not been deployed
3 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix metadata initialize for complex engines over cluster request.
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: