Backport of #94359 to 25.8.16: Allow positional arguments in distributed queries#1795
Open
ianton-ru wants to merge 1 commit into
Open
Backport of #94359 to 25.8.16: Allow positional arguments in distributed queries#1795ianton-ru wants to merge 1 commit into
ianton-ru wants to merge 1 commit into
Conversation
Allow positional arguments in distributed queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of ClickHouse#94359 by @simonmichal
Allow positional arguments in distributed queries
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow positional arguments in distributed queries (ClickHouse#94359 by @simonmichal)
Description
In ClickHouse#62289 positional argument substitution was disabled at remote, however in case of a view that can be expanded only in remote this can lead to NOT_AN_AGGREGATE error. This MR enables positional argument substitutions for views.
Tests
Using the reproducer from ClickHouse#89940 :
Making sure fix from ClickHouse#62289 is still working:
Comment for reviewer
Changes in
src/Processors/QueryPlan/ParallelReplicasLocalPlan.cppare reduced comparing with original PR.is replaced on
but in 25.8 code includes only one such place.
Others were added later, in ClickHouse#88696 and ClickHouse@7c8d833 (I did not find proper PR with this commit, so link only on the commit)
CI/CD Options
Exclude tests:
Regression jobs to run: